Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matter Temperature Sensor #17

Closed
wants to merge 21 commits into from
Closed

Matter Temperature Sensor #17

wants to merge 21 commits into from

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Oct 17, 2024

Add Matter Temperature Sensor:

  • Cluster
  • Device type

@lboue lboue marked this pull request as ready for review October 17, 2024 15:29
@lboue lboue marked this pull request as draft October 17, 2024 15:29
@lboue lboue marked this pull request as ready for review October 17, 2024 15:32
tannewt
tannewt requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Very excited to see it.

I've got a few small suggestions to better match the specs.

circuitmatter/clusters/general/temperature_measurement.py Outdated Show resolved Hide resolved
circuitmatter/clusters/general/temperature_measurement.py Outdated Show resolved Hide resolved
circuitmatter/clusters/general/temperature_measurement.py Outdated Show resolved Hide resolved
circuitmatter/device_types/measurement/temperature_sensor.py Outdated Show resolved Hide resolved
@lboue lboue mentioned this pull request Oct 19, 2024
Merged
@lboue
Copy link
Contributor Author

lboue commented Oct 19, 2024

Closing this in favor of #21.

@lboue lboue closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lboue @tannewt