fix service

circuitmatter/utility/mdns/zeroconf.py

@@ -21,27 +21,27 @@ def advertise_service(
         subtypes=[],
         instance_name="",
     ):
-        txt_records = [f"{key}={value}" for key, value in txt_records.items()]
+        txt_records = {key: value for key, value in txt_records.items()}
         main_info = ServiceInfo(
-            f"{service_type}.{protocol}.local",
-            instance_name,
+            f"{service_type}.{protocol}.local.",
+            f"{service_type}.{protocol}.local.",
             addresses=[socket.inet_aton("0.0.0.0")],
             port=port,
             properties=txt_records,
         )
-
-        sub_info = ServiceInfo(
-            subtypes,
-            instance_name,
-            addresses=[socket.inet_aton("0.0.0.0")],
-            port=port,
-            properties=txt_records,
-        )
-
         self.zeroconf.register_service(main_info)
-        self.zeroconf.register_service(sub_info)
         self.service_infos[service_type + instance_name] = main_info
-        self.service_infos[subtypes + instance_name] = sub_info
+
+        for subtype in subtypes:
+            sub_info = ServiceInfo(
+                f"{subtype}.local.",
+                f"{subtype}.local.",
+                addresses=[socket.inet_aton("0.0.0.0")],
+                port=port,
+                properties=txt_records,
+            )
+            self.service_infos[subtype] = sub_info
+            self.zeroconf.register_service(sub_info)
 
     def __del__(self):
         for service_info in self.service_infos.values():

examples/fake_onoff_led.py → fake_onoff_led.py

@@ -9,24 +9,24 @@
 
 
 class LED(on_off.OnOffLight):
-    def __init__(self, name, led):
+    def __init__(self, name):
         super().__init__(name)
         self._name = name
-        self._led = led
+        self.state = False
 
     def on(self):
-        self._led.value = True
+        self.state = True
         print("Led %s is On", self._name)
 
     def off(self):
-        self._led.value = False
+        self.state = False
         print("Led %s is Off", self._name)
 
 
 matter = cm.CircuitMatter()
-led = LED("led1")
-matter.add_device(led)
-led = LED("led2")
-matter.add_device(led)
+led1 = LED("led1")
+matter.add_device(led1)
+led2 = LED("led2")
+matter.add_device(led2)
 while True:
     matter.process_packets()