Skip to content

Commit

Permalink
Change NumberMembers to IntMembers
Browse files Browse the repository at this point in the history
This makes those struct fields show up as `int` when you hover them in
your editor. And will give red squiglies when assiging values with the
wrong type.
  • Loading branch information
CharString committed Jul 22, 2024
1 parent 4bd35ad commit b74a17d
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions circuitmatter/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

import binascii
import enum
import pathlib
import json
import os
import pathlib
import struct
import time

Expand Down Expand Up @@ -112,13 +112,13 @@ class SecureProtocolOpcode(enum.Enum):
# : UNSIGNED INTEGER [ range 16-bits ],
# }
class SessionParameterStruct(tlv.TLVStructure):
session_idle_interval = tlv.NumberMember(1, "<I", optional=True)
session_active_interval = tlv.NumberMember(2, "<I", optional=True)
session_active_threshold = tlv.NumberMember(3, "<H", optional=True)
data_model_revision = tlv.NumberMember(4, "<H")
interaction_model_revision = tlv.NumberMember(5, "<H")
specification_version = tlv.NumberMember(6, "<I")
max_paths_per_invoke = tlv.NumberMember(7, "<H")
session_idle_interval = tlv.IntMember(1, signed=False, octets=4, optional=True)
session_active_interval = tlv.IntMember(2, signed=False, octets=4, optional=True)
session_active_threshold = tlv.IntMember(3, signed=False, octets=2, optional=True)
data_model_revision = tlv.IntMember(4, signed=False, octets=2)
interaction_model_revision = tlv.IntMember(5, signed=False, octets=2)
specification_version = tlv.IntMember(6, signed=False, octets=4)
max_paths_per_invoke = tlv.IntMember(7, signed=False, octets=2)


# pbkdfparamreq-struct => STRUCTURE [ tag-order ]
Expand All @@ -135,8 +135,8 @@ class SessionParameterStruct(tlv.TLVStructure):
# }
class PBKDFParamRequest(tlv.TLVStructure):
initiatorRandom = tlv.OctetStringMember(1, 32)
initiatorSessionId = tlv.NumberMember(2, "<H")
passcodeId = tlv.NumberMember(3, "<H")
initiatorSessionId = tlv.IntMember(2, signed=False, octets=2)
passcodeId = tlv.IntMember(3, signed=False, octets=2)
hasPBKDFParameters = tlv.BoolMember(4)
initiatorSessionParams = tlv.StructMember(5, SessionParameterStruct, optional=True)

Expand All @@ -147,7 +147,7 @@ class PBKDFParamRequest(tlv.TLVStructure):
# salt [2] : OCTET STRING [ length 16..32 ],
# }
class Crypto_PBKDFParameterSet(tlv.TLVStructure):
iterations = tlv.NumberMember(1, "<I")
iterations = tlv.IntMember(1, signed=False, octets=4)
salt = tlv.OctetStringMember(2, 32)


Expand All @@ -166,7 +166,7 @@ class Crypto_PBKDFParameterSet(tlv.TLVStructure):
class PBKDFParamResponse(tlv.TLVStructure):
initiatorRandom = tlv.OctetStringMember(1, 32)
responderRandom = tlv.OctetStringMember(2, 32)
responderSessionId = tlv.NumberMember(3, "<H")
responderSessionId = tlv.IntMember(3, signed=False, octets=2)
pbkdf_parameters = tlv.StructMember(4, Crypto_PBKDFParameterSet)
responderSessionParams = tlv.StructMember(5, SessionParameterStruct, optional=True)

Expand Down

0 comments on commit b74a17d

Please sign in to comment.