feat: add support for SoftDevice S340 #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hathach
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
thank you for your PR. I have update the makefile/cmake a bit to make it easier to manage. And move the s340 note to its own readme.md.
Also the ci _s340 filter is also reverted, since I am not sure if it is a good idea to include s340 boards to this repo whereas those boards are not actually buildable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Description of Change
This PR adds the support for the SoftDevice S340 (with additional support for ANT/ANT+). The build for boards with S340 will only work locally after copying the closed source files in and the build is excluded for the build workflow on GitHub. Everything to do for S340 is documented in the README.md. Additionally an issue with disabling the SoftDevice has been fixed.