Added WisCore RAK4631 #322
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
requested changes
Feb 19, 2024
| //--------------------------------------------------------------------+ | ||
| // USB | ||
| //--------------------------------------------------------------------+ | ||
| #define USB_DESC_VID 0x239A |
There was a problem hiding this comment.
this VID and PID is already used for Adafruit product
| //------------- UF2 -------------// | ||
| #define UF2_PRODUCT_NAME "WisBlock RAK4631 Board" | ||
| #define UF2_VOLUME_LABEL "RAK4631" | ||
| #define UF2_BOARD_ID "WisBlock-RAK4631-Board" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
UF2_BOARD_IDin your board.h follow correct format from uf2 specsThis checklist items that are not applicable to your PR can be deleted.
Description of Change
Added RAK Wireless WisCore RAK4631 original change are coming from RAK
https://github.com/RAKWireless/WisBlock/tree/master/bootloader/RAK4630