Add caching for nanopb #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brentru this is ready for review |
tyeth
commented
Oct 25, 2024
tyeth
commented
Oct 25, 2024
|
Could we first attempt to grab the direct download, and then try the cached version? |
|
Sure that makes sense. I was initially leaning on the side of reducing
server load for nanopb
…On Fri, 25 Oct 2024, 15:05 Brent Rubell, ***@***.***> wrote:
Could we first attempt to grab the direct download, and then try the
cached version?
—
Reply to this email directly, view it on GitHub
<#652 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ42VF4VVQ5RBN2FB4QTZ5JFY7AVCNFSM6AAAAABQNIVN5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZXHA3TQMBRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@brentru should be good to go now |
brentru
approved these changes
Nov 15, 2024
|
@tyeth LGTM at your convenience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caches are based on the current ref, or a parent ref / base branch, as well as key.
When we update nanopb we'll need to update the cache key too, it's obvious as there are a few lines mentioning the version number.
This has now run once, causing a cached item to appear under the ref/pulls/this-one cache, and the second run has used that cached item for all the jobs.
Once we get it into main then one run will generate a cached item in the main cache which other things can utilise.