Regenerate displayconfig.json if erroneous #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #563 |
tyeth
force-pushed
the
funhouse-display-config-recreate
branch
from
d4017ab
to
989f666
Compare
|
@brentru this one is also ready for review |
|
@tyeth Can we hold on to this PR until we merge and release what's required for NO-OTA? |
|
We definitely can, although testing the noota was when I encountered the
issue.
The partition was corrupt but valid, and displayconfig was corrupt so board
stalled (no visual output too obviously)
…On Mon, 22 Apr 2024, 16:43 Brent Rubell, ***@***.***> wrote:
@tyeth <https://github.com/tyeth> Can we hold on to this PR until we
merge and release what's required for NO-OTA?
—
Reply to this email directly, view it on GitHub
<#575 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ43D5AORF5WTZFJIXZDY6UV3FAVCNFSM6AAAAABGTAH7BSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRZHE2TENJXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@tyeth Should we look at this again? |
|
Ah yes, also when secrets exists but is corrupt (usually 0bytes). I've been seeing some weird behaviour regarding first boot after installation (second boot gives more stable filesystem), but not pinned down anything definitive. |
|
Leaving this one open until file system corruption issue is resolved hopefully this week. It could go in as is, but there will be movement in same code areas as we try to avoid unnecessary file writes at boot. |
|
Note to add this when I do #655 |
tyeth
force-pushed
the
funhouse-display-config-recreate
branch
from
db2af9c
to
b7a915a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for the display config file to be corrupt, at which point the funhouse fails to continue.
It's a standard file we generate so this commit regenerates the file if erroneous