Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BMP280 #459

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Add BMP280 #459

merged 2 commits into from
Aug 1, 2023

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Jul 31, 2023

Closes adafruit/Wippersnapper_Components#135

There is a decision to be made about the sampling rates etc. The adafruit library has an example that states these to be the datasheet recommendataions, but the setSampling method has other defaults. As a result, for now, I have gone with the example parameters like so:

    // set up sampling as recommended in Adafruit library
    _bmp->setSampling(Adafruit_BMP280::MODE_NORMAL,  /* Operating Mode. */
                      Adafruit_BMP280::SAMPLING_X2,  /* Temp. oversampling */
                      Adafruit_BMP280::SAMPLING_X16, /* Pressure oversampling */
                      Adafruit_BMP280::FILTER_X16,   /* Filtering. */
                      Adafruit_BMP280::STANDBY_MS_500); /* Standby time. */

@brentru
Copy link
Member

brentru commented Jul 31, 2023

@tyeth I suggest to always use the default sampling modes as specified by the example, https://github.com/adafruit/Adafruit_BMP280_Library/blob/master/examples/bmp280test/bmp280test.ino#L49

@tyeth tyeth marked this pull request as ready for review August 1, 2023 10:23
@tyeth
Copy link
Contributor Author

tyeth commented Aug 1, 2023

image

Tested with one sensor, using alternate address (bridged ADDR jumper), on qtpy-s2

@tyeth tyeth requested a review from brentru August 1, 2023 10:30
@brentru
Copy link
Member

brentru commented Aug 1, 2023

@tyeth Could you resolve the conflict within library.properties?

@tyeth
Copy link
Contributor Author

tyeth commented Aug 1, 2023

@tyeth Could you resolve the conflict within library.properties?

@brentru Resolved 👍

@brentru
Copy link
Member

brentru commented Aug 1, 2023

Looks good! We'll add the altitude unit to Adafruit_Sensor and revise this driver once it's added.

@brentru brentru merged commit e79320a into adafruit:main Aug 1, 2023
24 checks passed
@tyeth tyeth deleted the add-BMP280 branch August 24, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants