add suggestions from Tyeth, src/components/i2c/WipperSnapper_I2C.cpp

adafruit · Aug 21, 2023 · ece56dd · ece56dd
1 parent c769a0d
commit ece56dd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/components/analogIO/Wippersnapper_AnalogIO.cpp b/src/components/analogIO/Wippersnapper_AnalogIO.cpp
@@ -329,7 +329,7 @@ void Wippersnapper_AnalogIO::update() {
     if (_analog_input_pins[i].enabled == true) {
 
       // Does the pin execute on-period?
-      if (millis() - _analog_input_pins[i].prvPeriod >
+      if ((long)millis() - _analog_input_pins[i].prvPeriod >
               _analog_input_pins[i].period &&
           _analog_input_pins[i].period != 0L) {
         WS_DEBUG_PRINT("Executing periodic event on A");

diff --git a/src/components/ds18x20/ws_ds18x20.cpp b/src/components/ds18x20/ws_ds18x20.cpp
@@ -30,7 +30,7 @@ ws_ds18x20::ws_ds18x20() {}
 /*************************************************************/
 ws_ds18x20::~ws_ds18x20() {
   // delete DallasTemp sensors and release onewire buses
-  for (int idx = 0; idx < _ds18xDrivers.size(); idx++) {
+  for (size_t idx = 0; idx < _ds18xDrivers.size(); idx++) {
     delete _ds18xDrivers[idx]->dallasTempObj;
     delete _ds18xDrivers[idx]->oneWire;
   }
@@ -185,7 +185,7 @@ void ws_ds18x20::update() {
     for (int i = 0; i < (*iter)->sensorPropertiesCount; i++) {
       // has sensor_period elapsed?
       if (curTime - (*iter)->sensorPeriodPrv >
-          (*iter)->sensorProperties[i].sensor_period) {
+          (long)(*iter)->sensorProperties[i].sensor_period) {
         // issue global temperature request to all DS sensors
         WS_DEBUG_PRINTLN("Requesting temperature..");
         (*iter)->dallasTempObj->requestTemperatures();

diff --git a/src/components/i2c/WipperSnapper_I2C.cpp b/src/components/i2c/WipperSnapper_I2C.cpp
@@ -492,7 +492,7 @@ void WipperSnapper_Component_I2C::updateI2CDeviceProperties(
   uint16_t i2cAddress = (uint16_t)msgDeviceUpdateReq->i2c_device_address;
 
   // Loop thru vector of drivers to find the unique address
-  for (int i = 0; i < drivers.size(); i++) {
+  for (size_t i = 0; i < drivers.size(); i++) {
     if (drivers[i]->getI2CAddress() == i2cAddress) {
       // Update the properties of each driver
       for (int j = 0; j < msgDeviceUpdateReq->i2c_device_properties_count;