Increase server name length in MQTT_FONA.h #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase the amount of characters to copy server name in the `connectServer` method from 40 to 60 to allow connecting to servers with a slightly longer FQDN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectServermethod from 40 to 60 to allow connecting to serverswith a slightly longer FQDN
Thank you for creating a pull request to contribute to Adafruit's GitHub code!
Before you open the request please review the following guidelines and tips to
help it be more easily integrated:
Describe the scope of your change--i.e. what the change does and what parts
of the code were modified. This modifies the server connection funcionality when connecting over GPRS with the FONA library. I updated the MQTT_FONA.h file.
Describe any known limitations with your change. This will still limit server name FQDN to 60 characters and not allow connections to them.
Please run any tests or examples that can exercise your modified code. Try to connect to
door-lock-dev.westeurope.azurecontainer.ioon port 1883 to see if you can successfully connect to it. I will leave the connection open to anonymous connections until the pull request is approved. This URL is 42 characters long and before this change connecting to the server was not possible, after I made this change I was able to connect to it