Adafruit_MQTT (API): the payload of publish method is read-only #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The payload param provided in publish is a const. This change
fixes the API to ensure caller that this is the case for all
variations of the publish method.
This is a proposed fix to issue #115
This change simply adds const to the proper data parameter, to
ensure that the payload provided is not modified by the MQTT
implementation. At the core of this codepath, the method
memmove() is invoked and that is very okay since the src parameter is a const as well.
There are no limitations regarding this change. If caller passes in a
non-const payload, the compiler will gladly handle it as a const anyway.
So, this is 100% backwards compatible.
To test this change, simply call the publish method providing a
const pointer. Example: