support 9.x and switch to ruff #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Jul 22, 2024
Comment on lines
+31
to
+32
| from busdisplay import BusDisplay | ||
| from fourwire import FourWire |
There was a problem hiding this comment.
Won't this break 8.x? We should wait until 8.x support is stopped to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: adafruit/Adafruit_CircuitPython_SSD1322#21 which needs to be fixed in this library as well.
Unrelated to the issue, but this PR also changes the library to use Ruff instead of pylint / black. My environment (py3.12) can't use pylint 2.17.4 so I would need to at least update that in order to run it. We discussed during the weeds of the meeting last week to start switching libraries over to Ruff as they need attention for other reasons so I've made the swap here.
If we're not ready for that change in this library yet though I can close this and make a PR with just the changes for 9.x