add program to compare template with fingerprint folfer #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plate with fingerprint folder
…plate with fingerprint folder
FoamyGuy
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Thanks for working on this @itsFDavid.
It looks mostly good to me, but there are a few tweaks I think should be:
- updating the copyright information
- add "rpi" at the end of the new filename to designate this example is not meant for microcontrollers
FoamyGuy
approved these changes
Nov 2, 2024
There was a problem hiding this comment.
This looks good to me, thank you @itsFDavid!
I didn't test on hardware but seems good to me.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 3, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint to 2.2.17 from 2.2.16: > Merge pull request adafruit/Adafruit_CircuitPython_Fingerprint#55 from itsFDavid/compare_with_file Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L1X to 1.2.0 from 1.1.16: > Merge pull request adafruit/Adafruit_CircuitPython_VL53L1X#20 from TheIllusionist77/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.1.5 from 3.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#210 from shubham0x13/main Updating https://github.com/adafruit/Adafruit_CircuitPython_TemplateEngine to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_TemplateEngine#5 from michalpokusa/fixes-and-refactor Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added example of program to compare fingerprint with template folder and added more functions how that store image, store template on fingerprint folder, store model on sensor