Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Permit serving .well-known directories #3519

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AverageHelper
Copy link

@AverageHelper AverageHelper commented Dec 9, 2024

PR Type

Bug Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Previously, when hidden files are disallowed, the .well-known directory is also disallowed. There are several cases where a webserver might serve one or more static files from that directory, so actix-files should permit that behavior without needing to allow reading all hidden files.

With this change, segments that match ".well-known" are exempt from the hidden-files check.

@AverageHelper AverageHelper changed the title Permit serving .well-known directories fix(files): Permit serving .well-known directories Dec 9, 2024
@AverageHelper AverageHelper marked this pull request as ready for review December 9, 2024 00:52
@AverageHelper AverageHelper marked this pull request as draft December 9, 2024 00:59
@AverageHelper AverageHelper marked this pull request as ready for review December 9, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant