Open
Conversation
c75c46d to
3d17c3f
Compare
robjtede
requested changes
Aug 19, 2024
3d17c3f to
f96a21f
Compare
Author
|
@robjtede those changes have been made. Let me know if you have any more feedback. |
Author
|
I'm still interested in this patch, if you think it's worth merging in. |
Member
|
Just come back to this and I still like it, but I'm going to make the I'll cut a release with what's been merged already and get to this one afterwards. Should be easy to fixup and get out this weekend. |
Member
|
Run into a hurdle with that idea, that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
This adds the
Location,Content-LocationandReferertyped headers. It also adds theTryIntoHeaderValuetrait forUriwhich allowsUrito be a typed value for these headers.While
Locationtechnically is a different type thanContent-LocationandReferer(Locationallows for protocol relative URIs) I think it's not a large enough distinction to warrant a separate type, as using protocol relative urls is quite rare. However we could useurl::Urlinstead ofUriforLocationif we wanted to allow for that distinction.The motivation for this PR is to allow for using
Refereras an Extractor, and the other two were easy enough to also add, and complete the trifecta of URI related headers (to the best of my knowledge).