Draft
Conversation
robjtede
reviewed
Mar 16, 2024
| method_macro!(Options, options); | ||
| method_macro!(Trace, trace); | ||
| method_macro!(Patch, patch); | ||
| method_macro!(All, all); |
Member
There was a problem hiding this comment.
This will almost certainly be easier with a new macro creator rather than trying to retro-fit method_macro!
Author
There was a problem hiding this comment.
Is making a custom http server and defining any a way or is there a better way? @robjtede
Member
There was a problem hiding this comment.
What it would need to generate would be similar to the other macros (an HttpServiceFactory implementation) except without adding any method guards to the route.
Author
There was a problem hiding this comment.
I am sorry but I am not sure if I understand @robjtede
Author
robjtede
reviewed
Mar 16, 2024
Comment on lines
+6
to
+9
| #[route("/single", method = "ALL")] | ||
| async fn index() -> String { | ||
| "Hello Single!".to_owned() | ||
| } |
Member
There was a problem hiding this comment.
I think we were trying to aim more so for the dedicated macro style:
#[any("/path")]
async handler() {
// ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR Type
It's a draft PR for progress checking DRAFT PRPR_TYPE
PR Checklist
Overview