Add feature for limit request to log in middleware logger using status code#3086
Open
tglman wants to merge 5 commits intoactix:mainfrom
Open
Add feature for limit request to log in middleware logger using status code#3086tglman wants to merge 5 commits intoactix:mainfrom
tglman wants to merge 5 commits intoactix:mainfrom
Conversation
Contributor
Author
|
Hi, I did add a simple dev-dependency to capture logs and check them in the tests, so I could add some tests that check the full flow, I updated also some existing tests to check that the output is what is expected. Now this PR should be complete of all the requirements. Regards |
5 tasks
5 tasks
Member
|
The only problem I see with this is the issue of disjoint ranges. I can see it being reasonable to want everything except redirects being logged; in which case it's either:
It's tempting to go with the set subtraction technique since more common patterns can be expressed with just one builder method. Despite being terse, it might be confusing, too. So, the API could be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is yet a preliminary change to just collect feedback:
So this PR add a new feature on the logger middleware, to limit the logging to a range of status code, so that are logged only some specific status in the range, a simple example that will log only the 400+ request/responses is:
Do you like this API is the naming right or you prefer a different one ?
Do you like this? shall I continue 😄 ?
PR Checklist
Could not really find a simple way to test this without an application, I didn't see any similar tests for other similar features where could I find/plug a test case for this case ?
work in progress
will do