Fix always use build associated #312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You found the issue, but then you changed the test. Order is changed if build_associated is used. |
|
I was thinking the order is irrelevant. I'll look into how the order can be preserved and resubmit. |
|
It was one of the issues. When you create some lines in subform, and when you edit you see lines in subform in a different order, in some cases it can be confusing for users so ActiveScaffold should preserve order. Another issue was on has_one associations on rails4, but finally I had to change send("#{column.name}=", value) line. if you can use build_associated and original tests pass, it should be ok |
scambra
force-pushed
the
master
branch
2 times, most recently
from
2671ef6
to
e186793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry for #310
I fixed the 2 tests that were failing.
If there are other issues please let me know.