-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(piece-framework): support array of objects #2960
feat(piece-framework): support array of objects #2960
Conversation
Hi @Awais000 give me some more time, I am going to get back to that soon! Sorry |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8f0110f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
@Awais000, very useful feature! Thanks! Just out of curiosity, is there a way to make one property's config depend on the value from another property ( both properties being in the same array )? |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit aa98b41. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Thank you, @Anomaly314, for this great contribution. As we discussed, let's temporarily remove the dynamic dropdown and dynamic properties, and then merge that. I have merged with the main branch and pushed the changes we discussed. @AbdulTheActivePiecer, could you please take a look at the user interface and make the necessary changes? I believe we should take look at the design of groups at #3206 and ensure that we have a design for grouping (card), that we will be using in both these feature. @AbdulTheActivePiecer I have pushed an edits to hackernews, I will revert them before we merge to main, as they are just for testing. So please checkout the branch and check hackernews piece. |
Hi there guys, I adjusted some stuff in the UI code to make it more coherent with our design, thanks a lot @Anomaly314. |
feat: add nested property access support in array for nested forms
Testing:
Manual testing confirms that refreshers mechanisms, dynamic property assignment, and validations are fully functional.
Sample Code: