Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule DMLCheckScanRowsDesc cancel checking of type of sql explain #2859

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

winfredLIN
Copy link
Collaborator

关联的 issue

#2857

描述你的变更

  1. 规则:扫描行数超过阈值,筛选条件必须带上主键或者索引,名称变更为:扫描行数超过阈值,请检查索引配置
  2. 取消规则中对SQL执行计划中type类型的检测,转而一旦扫描行数超过阈值就触发规则
  3. 调整单元测试预期结果

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc

@winfredLIN winfredLIN self-assigned this Jan 7, 2025
@BugsGuru BugsGuru merged commit 796cbd0 into main Jan 7, 2025
3 checks passed
@BugsGuru BugsGuru deleted the 2587 branch January 7, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants