Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create jdk dir and update sqled.spec #2853

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix: create jdk dir and update sqled.spec #2853

merged 1 commit into from
Jan 3, 2025

Conversation

littleniannian
Copy link
Collaborator

关联的 issue

https://github.com/actiontech/sqle-ee/issues/2116

描述你的变更

  • 创建空的jdk目录用于和gocd 社区版打包的解耦合

确认项（pr提交后操作）

Tip

请在指定复审人之前，确认并完成以下事项，完成后✅

  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性，如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档，如果要更新则在issue里标记 need_update_doc

@littleniannian
Copy link
Collaborator Author

TODO: 这里使用空文件的方式创建jdk目录来使和gocd社区版打包解耦不是很优雅

@LordofAvernus LordofAvernus merged commit 4e136f6 into main Jan 3, 2025
3 checks passed
@littleniannian littleniannian deleted the fix_jdk_dir branch January 6, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordofAvernus LordofAvernus LordofAvernus approved these changes

@BugsGuru BugsGuru BugsGuru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littleniannian @LordofAvernus @BugsGuru