modify: enhance three star advisor and fix a problem #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Treating the column of the in statement as a non equivalent column 2. Fill in selectivity when extracting columns from SQL statements 3. Added exclude fields of type JSON as part of the index 4. Fixed the issue of inaccurate coverage index judgment 5. Added display of single column index when Samsung Index suggests providing single column index
winfredLIN
commented
Dec 15, 2023
sqle/driver/mysql/advisor.go
Outdated
Comment on lines
713
to
716
| // 一旦SQL中有列不适合作为索引的列，则无法给出覆盖索引 | ||
| if a.columnShouldNotAdd.len() > 0 { | ||
| return false | ||
| } |
1. Delete columnShouldNotAdd and selectivityMap structure members 2. Add members of the drivingTableColumnMap structure to record the mapping of column names and column objects 3. Fix: Fix the delete method for columnGroup
|
sjjian
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2154