Merge pull request #2886 from actiontech/fix_missing_return_rule_error

fix: scannerd go test, add error nil judgment
actiontech · Jan 21, 2025 · c596082 · c596082
2 parents fdba800 + e0752ed
commit c596082
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/sqle/cmd/scannerd/scanners/supervisor/supervisor.go b/sqle/cmd/scannerd/scanners/supervisor/supervisor.go
@@ -29,9 +29,11 @@ func Start(ctx context.Context, scanner scanners.Scanner, leastPushSecond, pushB
 	for {
 		select {
 		case err := <-runErrCh:
-			UploadErr := scanner.Upload(context.TODO(), batch, err.Error())
-			if UploadErr != nil {
-				return errors.Wrap(UploadErr, "failed to upload sql")
+			if err != nil {
+				UploadErr := scanner.Upload(context.TODO(), batch, err.Error())
+				if UploadErr != nil {
+					return errors.Wrap(UploadErr, "failed to upload sql")
+				}
 			}
 			return err