cache: add support for zstd --adapt
#1772
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smorimoto
commented
Jul 23, 2024
Comment on lines
-105
to
+112
| if (versionOutput === '') { | ||
| if (version === null) { | ||
| return CompressionMethod.Gzip | ||
| } else { | ||
| } else if (semver.lt(version, '1.3.2')) { | ||
| return CompressionMethod.ZstdWithoutLong | ||
| } else if (semver.lt(version, '1.3.6')) { | ||
| return CompressionMethod.ZstdWithoutAdapt | ||
| } else { | ||
| return CompressionMethod.Zstd |
There was a problem hiding this comment.
This should also fix this bug, as it seems we have not actually been able to use long mode yet.
smorimoto
commented
Jul 23, 2024
| @@ -207,6 +207,7 @@ async function getDecompressionProgram( | |||
| // Used for creating the archive | |||
| // -T#: Compress using # working thread. If # is 0, attempt to detect and use the number of physical CPU cores. | |||
| // zstdmt is equivalent to 'zstd -T0' | |||
| // --adapt: Dynamically adapt compression level to I/O conditions. | |||
There was a problem hiding this comment.
Signed-off-by: Sora Morimoto <[email protected]>
|
Ready to merge! |
|
Gentle ping @robherley |
|
@robherley ping |
|
@nebuk89 How do we move this forward? |
|
Gentle reminder |
|
@joshmgross ping |
|
ping @joshmgross |
|
👋 Hey @smorimoto, Thank you for this change! I don't think we have capacity to fully validate and test this change at the moment, but I'll keep in mind in the future when we're ready to invest more in this cache package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I remember correctly, we had that support before, but somehow it seems to have been removed at some point. This PR not only brings it back to keep the cache toolkit fast, but also "actually" enables long mode as described below.
At least the official GitHub Actions images have fairly new zstd installed on all platforms, so once merged we get all the benefits.