Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unformatted trace logging for step telemetry in ExecutionContext #3581

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unformatted trace logging for step telemetry in ExecutionContext #3581

wants to merge 1 commit into from

Commits on Nov 19, 2024

  1. Unformatted trace logging for step telemetry in ExecutionContext 

    Don't apply JSON formatting during the trace logging for step telemetry.
By default `StringUtil.ConvertToJson` uses `Formatting.Indented` which
causes multi-line logs for this particular json object.

The data contained in this particular log line is useful for operators
of self-hosted runners who are looking to use log aggregates to
understand their overall usage and performance. Parsing multi-line data
in log aggregates is very hard to get right, if not outright impossible
depending on how logs are aggregated.
    @carlosdagos
    carlosdagos committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2389f03 View commit details
    Browse the repository at this point in the history