Fix the max comment length issue #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bteng22
requested changes
May 6, 2024
There was a problem hiding this comment.
Nice work around for the max length issue 👍 Did you need this PR merged for your demo? If not immediate, let's remove some of the duplication like you mentioned and add some tests for getMinSummaryForComment
Also is there a test repo you were running this against?
|
@jhutchings1 can I help get this merged? we're starting to see this happen with dependency-review frequently. |
|
This was enough to unblock my demos, but I would love for the team to take
this across the line if you have cycles. @bteng22, happy for an assist
here!
Justin Hutchings | Senior Director of Product Management | GitHub -
Security | <https://www.github.com/jhutchings1>
<https://www.linkedin.com/in/hutchingsjustin/>
<https://www.linkedin.com/in/hutchingsjustin/>
…On Wed, May 15, 2024 at 11:05 PM Cameron Cooper ***@***.***> wrote:
@jhutchings1 <https://github.com/jhutchings1> can I help get this merged?
we're starting to see this happen with dependency-review frequently.
—
Reply to this email directly, view it on GitHub
<#767 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADCCCIYSVZNBWD3OK26B7OLZCOBUTAVCNFSM6AAAAABHIFIIC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSHEZTQNRTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Update
I think this should be ready for review cc @hmaurer @bteng22 🙇 |
elireisman
force-pushed
the
max-comment-length
branch
2 times, most recently
from
135a5f2
to
dbf658f
Compare
elireisman
force-pushed
the
max-comment-length
branch
from
9eb6530
to
087d0f8
Compare
bteng22
previously approved these changes
Jun 4, 2024
Co-authored-by: Brandon Teng <[email protected]>
|
👍 @bteng22 let me know what you think - I committed your suggestion, if this is looking right to you I can update the EDIT: updated, let me know what you think of the changes 👍 |
Racer159
pushed a commit
to defenseunicorns/maru-runner
that referenced
this pull request
Jun 7, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/create-github-app-token](https://togithub.com/actions/create-github-app-token) | action | patch | `v1.10.0` -> `v1.10.1` | | [actions/dependency-review-action](https://togithub.com/actions/dependency-review-action) | action | patch | `v4.3.2` -> `v4.3.3` | | [defenseunicorns/zarf](https://togithub.com/defenseunicorns/zarf) | | minor | `v0.33.2` -> `v0.34.0` | | [github/codeql-action](https://togithub.com/github/codeql-action) | action | patch | `v3.25.6` -> `v3.25.8` | --- ### Release Notes <details> <summary>actions/create-github-app-token (actions/create-github-app-token)</summary> ### [`v1.10.1`](https://togithub.com/actions/create-github-app-token/releases/tag/v1.10.1) [Compare Source](https://togithub.com/actions/create-github-app-token/compare/v1.10.0...v1.10.1) ##### Bug Fixes - **deps:** bump the production-dependencies group with 2 updates ([#​138](https://togithub.com/actions/create-github-app-token/issues/138)) ([8d81a59](https://togithub.com/actions/create-github-app-token/commit/8d81a59103d6d17f5ecc243eb5fd53757607a1d2)), closes [#​606](https://togithub.com/actions/create-github-app-token/issues/606) [#​606](https://togithub.com/actions/create-github-app-token/issues/606) [#​605](https://togithub.com/actions/create-github-app-token/issues/605) [#​604](https://togithub.com/actions/create-github-app-token/issues/604) [nodejs/undici#3295](https://togithub.com/nodejs/undici/issues/3295) [nodejs/undici#3298](https://togithub.com/nodejs/undici/issues/3298) [nodejs/undici#3294](https://togithub.com/nodejs/undici/issues/3294) [nodejs/undici#3281](https://togithub.com/nodejs/undici/issues/3281) [nodejs/undici#3286](https://togithub.com/nodejs/undici/issues/3286) [nodejs/undici#3284](https://togithub.com/nodejs/undici/issues/3284) [nodejs/undici#3291](https://togithub.com/nodejs/undici/issues/3291) [nodejs/undici#3290](https://togithub.com/nodejs/undici/issues/3290) [nodejs/undici#3283](https://togithub.com/nodejs/undici/issues/3283) [nodejs/undici#3281](https://togithub.com/nodejs/undici/issues/3281) [nodejs/undici#3263](https://togithub.com/nodejs/undici/issues/3263) [nodejs/undici#3279](https://togithub.com/nodejs/undici/issues/3279) [nodejs/undici#3227](https://togithub.com/nodejs/undici/issues/3227) [nodejs/undici#3234](https://togithub.com/nodejs/undici/issues/3234) [nodejs/undici#3240](https://togithub.com/nodejs/undici/issues/3240) [nodejs/undici#3245](https://togithub.com/nodejs/undici/issues/3245) [nodejs/undici#3241](https://togithub.com/nodejs/undici/issues/3241) [nodejs/undici#3247](https://togithub.com/nodejs/undici/issues/3247) [nodejs/undici#3248](https://togithub.com/nodejs/undici/issues/3248) [nodejs/undici#3219](https://togithub.com/nodejs/undici/issues/3219) [nodejs/undici#3251](https://togithub.com/nodejs/undici/issues/3251) [nodejs/undici#3254](https://togithub.com/nodejs/undici/issues/3254) [nodejs/undici#3258](https://togithub.com/nodejs/undici/issues/3258) [nodejs/undici#3257](https://togithub.com/nodejs/undici/issues/3257) [nodejs/undici#3259](https://togithub.com/nodejs/undici/issues/3259) [nodejs/undici#3262](https://togithub.com/nodejs/undici/issues/3262) [nodejs/undici#3264](https://togithub.com/nodejs/undici/issues/3264) [nodejs/undici#3118](https://togithub.com/nodejs/undici/issues/3118) [nodejs/undici#3269](https://togithub.com/nodejs/undici/issues/3269) [#​3301](https://togithub.com/actions/create-github-app-token/issues/3301) [#​3294](https://togithub.com/actions/create-github-app-token/issues/3294) [#​3298](https://togithub.com/actions/create-github-app-token/issues/3298) [#​3295](https://togithub.com/actions/create-github-app-token/issues/3295) [#​3293](https://togithub.com/actions/create-github-app-token/issues/3293) [#​3283](https://togithub.com/actions/create-github-app-token/issues/3283) [#​3290](https://togithub.com/actions/create-github-app-token/issues/3290) [#​3291](https://togithub.com/actions/create-github-app-token/issues/3291) [#​3284](https://togithub.com/actions/create-github-app-token/issues/3284) [#​3286](https://togithub.com/actions/create-github-app-token/issues/3286) </details> <details> <summary>actions/dependency-review-action (actions/dependency-review-action)</summary> ### [`v4.3.3`](https://togithub.com/actions/dependency-review-action/releases/tag/v4.3.3): Notes for v4.3.3 [Compare Source](https://togithub.com/actions/dependency-review-action/compare/v4.3.2...v4.3.3) #### What's Changed - Allow slashes in purl package names by [@​juxtin](https://togithub.com/juxtin) in [actions/dependency-review-action#765 - use the v3 version of the deps.dev API by [@​josieang](https://togithub.com/josieang) in [actions/dependency-review-action#741 - PR with suggestions - \[Improvement]: Help streamline / simplify dependency review action README by [@​am-stead](https://togithub.com/am-stead) in [actions/dependency-review-action#773 - fix show-openssf-scorecard-levels input by [@​ramann](https://togithub.com/ramann) in [actions/dependency-review-action#776 - Updates to the contribution guidelines by [@​jonjanego](https://togithub.com/jonjanego) in [actions/dependency-review-action#778 - Create issue templates by [@​jonjanego](https://togithub.com/jonjanego) in [actions/dependency-review-action#777 - Fix the max comment length issue by [@​jhutchings1](https://togithub.com/jhutchings1) and [@​elireisman](https://togithub.com/elireisman) in [actions/dependency-review-action#767 - Bump project version to 4.3.3 in prep for a release by [@​elireisman](https://togithub.com/elireisman) in [actions/dependency-review-action#781 #### New Contributors - [@​josieang](https://togithub.com/josieang) made their first contribution in [actions/dependency-review-action#741 - [@​am-stead](https://togithub.com/am-stead) made their first contribution in [actions/dependency-review-action#773 - [@​ramann](https://togithub.com/ramann) made their first contribution in [actions/dependency-review-action#776 **Full Changelog**: actions/dependency-review-action@v4.3.2...v4.3.3 </details> <details> <summary>defenseunicorns/zarf (defenseunicorns/zarf)</summary> ### [`v0.34.0`](https://togithub.com/defenseunicorns/zarf/releases/tag/v0.34.0) [Compare Source](https://togithub.com/defenseunicorns/zarf/compare/v0.33.2...v0.34.0) #### What's Changed - refactor: move validate to expose it as receivers by [@​Noxsios](https://togithub.com/Noxsios) in [defenseunicorns/zarf#2419 - docs: add additional detail to security policy by [@​salaxander](https://togithub.com/salaxander) in [defenseunicorns/zarf#2488 - chore: cleanup stale grype ignores and patch golang.org/x/net CVE by [@​lucasrod16](https://togithub.com/lucasrod16) in [defenseunicorns/zarf#2492 - docs: injector and init package reference material by [@​Noxsios](https://togithub.com/Noxsios) in [defenseunicorns/zarf#2468 - chore: patch CVE-2024-3817 by [@​lucasrod16](https://togithub.com/lucasrod16) in [defenseunicorns/zarf#2498 - refactor: cleaner image pulls by [@​Noxsios](https://togithub.com/Noxsios) in [defenseunicorns/zarf#2460 - chore: adding [@​dgershman](https://togithub.com/dgershman) by [@​dgershman](https://togithub.com/dgershman) in [defenseunicorns/zarf#2506 - refactor: context usage in k8s code by [@​lucasrod16](https://togithub.com/lucasrod16) in [defenseunicorns/zarf#2405 - ci: run revive using golang-lint-ci by [@​phillebaba](https://togithub.com/phillebaba) in [defenseunicorns/zarf#2499 - feat: update injector away from rouille to axum by [@​schristoff](https://togithub.com/schristoff) in [defenseunicorns/zarf#2457 - refactor: enable testifylint linter by [@​phillebaba](https://togithub.com/phillebaba) in [defenseunicorns/zarf#2504 - chore: remove rouille CVE from grype ignore by [@​lucasrod16](https://togithub.com/lucasrod16) in [defenseunicorns/zarf#2515 - fix(agent): missing path for pod without labels by [@​brandtkeller](https://togithub.com/brandtkeller) in [defenseunicorns/zarf#2518 - fix: adopt namespace metadata by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [defenseunicorns/zarf#2494 - refactor: enable ineffassign linter by [@​phillebaba](https://togithub.com/phillebaba) in [defenseunicorns/zarf#2500 - test: cluster getDeployedPackages by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [defenseunicorns/zarf#2523 - test: add unit tests for merge zarf state by [@​phillebaba](https://togithub.com/phillebaba) in [defenseunicorns/zarf#2522 - test: pod agent unit tests by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [defenseunicorns/zarf#2526 - docs: add google analytics for docs pages by [@​salaxander](https://togithub.com/salaxander) in [defenseunicorns/zarf#2530 - test: add unit tests for detect distro by [@​phillebaba](https://togithub.com/phillebaba) in [defenseunicorns/zarf#2521 - test: add tests for injector by [@​phillebaba](https://togithub.com/phillebaba) in [defenseunicorns/zarf#2534 - chore: add codecov by [@​schristoff-du](https://togithub.com/schristoff-du) in [defenseunicorns/zarf#2529 - chore: add unit tests for creator.LoadPackageDefinition by [@​lucasrod16](https://togithub.com/lucasrod16) in [defenseunicorns/zarf#2531 - test: refactor network test by [@​phillebaba](https://togithub.com/phillebaba) in [defenseunicorns/zarf#2533 - test: agent flux unit test by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [defenseunicorns/zarf#2528 - chore: fix codecov by [@​schristoff](https://togithub.com/schristoff) in [defenseunicorns/zarf#2538 - test: creator.ComposeComponents by [@​lucasrod16](https://togithub.com/lucasrod16) in [defenseunicorns/zarf#2537 - refactor: remove use of k8s serivce account by [@​phillebaba](https://togithub.com/phillebaba) in [defenseunicorns/zarf#2544 - refactor: remove use of k8s service by [@​phillebaba](https://togithub.com/phillebaba) in [defenseunicorns/zarf#2543 - refactor: remove use of k8s configmap by [@​phillebaba](https://togithub.com/phillebaba) in [defenseunicorns/zarf#2541 - refactor: remove use of k8s hpa by [@​phillebaba](https://togithub.com/phillebaba) in [defenseunicorns/zarf#2542 - test: add secrets tests by [@​phillebaba](https://togithub.com/phillebaba) in [defenseunicorns/zarf#2540 - refactor: allow callers to directly set logfile location by [@​Noxsios](https://togithub.com/Noxsios) in [defenseunicorns/zarf#2545 - test: add test for packager source by [@​phillebaba](https://togithub.com/phillebaba) in [defenseunicorns/zarf#2525 - chore: add unit tests to variables pkg by [@​Racer159](https://togithub.com/Racer159) in [defenseunicorns/zarf#2519 - test: clean up tests for composer by [@​phillebaba](https://togithub.com/phillebaba) in [defenseunicorns/zarf#2532 - test: argo agent unit tests by [@​AustinAbro321](https://togithub.com/AustinAbro321) in [defenseunicorns/zarf#2536 - fix(release): do not delete testdata in release workflow by [@​lucasrod16](https://togithub.com/lucasrod16) in [defenseunicorns/zarf#2547 **Full Changelog**: defenseunicorns/zarf@v0.33.2...v0.34.0 </details> <details> <summary>github/codeql-action (github/codeql-action)</summary> ### [`v3.25.8`](https://togithub.com/github/codeql-action/compare/v3.25.7...v3.25.8) [Compare Source](https://togithub.com/github/codeql-action/compare/v3.25.7...v3.25.8) ### [`v3.25.7`](https://togithub.com/github/codeql-action/compare/v3.25.6...v3.25.7) [Compare Source](https://togithub.com/github/codeql-action/compare/v3.25.6...v3.25.7) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 12pm every weekday,before 11am every weekday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/maru-runner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsic3VwcG9ydC1kZXBzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Racer159
added a commit
to defenseunicorns/uds-package-gitlab-runner
that referenced
this pull request
Jun 9, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/dependency-review-action](https://togithub.com/actions/dependency-review-action) | action | patch | `v4.3.2` -> `v4.3.3` | | [defenseunicorns/uds-cli](https://togithub.com/defenseunicorns/uds-cli) | | minor | `v0.10.4` -> `v0.11.0` | | [defenseunicorns/uds-common](https://togithub.com/defenseunicorns/uds-common) | | patch | `v0.4.4` -> `v0.4.5` | | [defenseunicorns/uds-common](https://togithub.com/defenseunicorns/uds-common) | action | patch | `v0.4.4` -> `v0.4.5` | | [github/codeql-action](https://togithub.com/github/codeql-action) | action | patch | `v3.25.6` -> `v3.25.8` | --- ### Release Notes <details> <summary>actions/dependency-review-action (actions/dependency-review-action)</summary> ### [`v4.3.3`](https://togithub.com/actions/dependency-review-action/releases/tag/v4.3.3): Notes for v4.3.3 [Compare Source](https://togithub.com/actions/dependency-review-action/compare/v4.3.2...v4.3.3) #### What's Changed - Allow slashes in purl package names by [@​juxtin](https://togithub.com/juxtin) in [actions/dependency-review-action#765 - use the v3 version of the deps.dev API by [@​josieang](https://togithub.com/josieang) in [actions/dependency-review-action#741 - PR with suggestions - \[Improvement]: Help streamline / simplify dependency review action README by [@​am-stead](https://togithub.com/am-stead) in [actions/dependency-review-action#773 - fix show-openssf-scorecard-levels input by [@​ramann](https://togithub.com/ramann) in [actions/dependency-review-action#776 - Updates to the contribution guidelines by [@​jonjanego](https://togithub.com/jonjanego) in [actions/dependency-review-action#778 - Create issue templates by [@​jonjanego](https://togithub.com/jonjanego) in [actions/dependency-review-action#777 - Fix the max comment length issue by [@​jhutchings1](https://togithub.com/jhutchings1) and [@​elireisman](https://togithub.com/elireisman) in [actions/dependency-review-action#767 - Bump project version to 4.3.3 in prep for a release by [@​elireisman](https://togithub.com/elireisman) in [actions/dependency-review-action#781 #### New Contributors - [@​josieang](https://togithub.com/josieang) made their first contribution in [actions/dependency-review-action#741 - [@​am-stead](https://togithub.com/am-stead) made their first contribution in [actions/dependency-review-action#773 - [@​ramann](https://togithub.com/ramann) made their first contribution in [actions/dependency-review-action#776 **Full Changelog**: actions/dependency-review-action@v4.3.2...v4.3.3 </details> <details> <summary>defenseunicorns/uds-cli (defenseunicorns/uds-cli)</summary> ### [`v0.11.0`](https://togithub.com/defenseunicorns/uds-cli/releases/tag/v0.11.0) [Compare Source](https://togithub.com/defenseunicorns/uds-cli/compare/v0.10.4...v0.11.0) ##### What's Changed - chore(deps): update actions/upload-artifact action to v4.3.2 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#574 - fix(deps): update golang.org/x/exp digest to [`fe59bbe`](https://togithub.com/defenseunicorns/uds-cli/commit/fe59bbe) by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#571 - chore(deps): update github/codeql-action action to v3.25.1 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#570 - fix(deps): update module github.com/defenseunicorns/pkg/oci to v0.0.2 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#576 - fix: permit absolute paths for bundle create by [@​ZachGallagher](https://togithub.com/ZachGallagher) in [defenseunicorns/uds-cli#554 - fix: ensure we handle paths correctly in dev deploy by [@​UncleGedd](https://togithub.com/UncleGedd) in [defenseunicorns/uds-cli#582 - chore(deps): update actions/download-artifact action to v4.1.7 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#573 - fix(deps): update module github.com/defenseunicorns/pkg/helpers to v1.1.1 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#575 - chore(deps): update actions/checkout action to v4.1.4 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#578 - chore(deps): update actions/upload-artifact action to v4.3.3 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#579 - chore(deps): update github/codeql-action action to v3.25.3 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#580 - chore(deps): update anchore/sbom-action action to v0.15.11 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#587 - chore: ensure vendored tools versions print out by [@​TristanHoladay](https://togithub.com/TristanHoladay) in [defenseunicorns/uds-cli#586 - chore(deps): update actions/checkout action to v4.1.5 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#597 - chore(deps): update github/codeql-action action to v3.25.4 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#595 - fix(deps): update module golang.org/x/exp to v0.0.0-20240506185415-9bf2ced13842 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#593 - chore(deps): update actions/setup-go action to v5.0.1 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#590 - chore: update contributing doc by [@​UncleGedd](https://togithub.com/UncleGedd) in [defenseunicorns/uds-cli#598 - chore: swap Makefile for Maru by [@​UncleGedd](https://togithub.com/UncleGedd) in [defenseunicorns/uds-cli#602 - chore(deps): update github/codeql-action action to v3.25.5 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#606 - fix(deps): update module github.com/defenseunicorns/pkg/helpers to v1.1.2 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#605 - chore(deps): update ossf/scorecard-action action to v2.3.3 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#601 - chore(deps): update goreleaser/goreleaser-action action to v5.1.0 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#604 - chore: bump Go version to 1.21.10 by [@​UncleGedd](https://togithub.com/UncleGedd) in [defenseunicorns/uds-cli#609 - feat: remove q for canceling deploy by [@​UncleGedd](https://togithub.com/UncleGedd) in [defenseunicorns/uds-cli#603 - chore: remove dead end code by [@​UncleGedd](https://togithub.com/UncleGedd) in [defenseunicorns/uds-cli#611 - chore: test getArch by [@​TristanHoladay](https://togithub.com/TristanHoladay) in [defenseunicorns/uds-cli#621 - chore(deps): update actions/checkout action to v4.1.6 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#619 - chore(deps): update homebrew/actions digest to [`677db44`](https://togithub.com/defenseunicorns/uds-cli/commit/677db44) by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#620 - chore(deps): update github/codeql-action action to v3.25.6 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#625 - chore(deps): update anchore/sbom-action action to v0.16.0 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#623 - feat: allow helm overrides from valuesfile by [@​decleaver](https://togithub.com/decleaver) in [defenseunicorns/uds-cli#594 - chore: removes bubbletea tui by [@​UncleGedd](https://togithub.com/UncleGedd) in [defenseunicorns/uds-cli#626 - chore: update linting configuration by [@​TristanHoladay](https://togithub.com/TristanHoladay) in [defenseunicorns/uds-cli#627 - docs: dev deploy ADR by [@​decleaver](https://togithub.com/decleaver) in [defenseunicorns/uds-cli#560 - fix(deps): update module helm.sh/helm/v3 to v3.15.0 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#612 - feat: strict bundle yaml validation by [@​decleaver](https://togithub.com/decleaver) in [defenseunicorns/uds-cli#596 - feat: dev deploy remote bundles by [@​decleaver](https://togithub.com/decleaver) in [defenseunicorns/uds-cli#629 - chore: update to de-zarfed Maru by [@​Racer159](https://togithub.com/Racer159) in [defenseunicorns/uds-cli#636 - fix(deps): update module helm.sh/helm/v3 to v3.15.1 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#634 - chore(deps): update docker/login-action action to v3.2.0 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#640 - chore(deps): update homebrew/actions digest to [`a618804`](https://togithub.com/defenseunicorns/uds-cli/commit/a618804) by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#632 - fix(deps): update golang.org/x/exp digest to [`4c93da0`](https://togithub.com/defenseunicorns/uds-cli/commit/4c93da0) by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#639 - chore(deps): update podinfo to v6.6.3 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#633 - chore(deps): update zarf to v0.33.1 by [@​renovate](https://togithub.com/renovate) in [defenseunicorns/uds-cli#585 - feat: remove unnecessary bundle layers and refactor verification by [@​UncleGedd](https://togithub.com/UncleGedd) in [defenseunicorns/uds-cli#622 - feat: uds config validation by [@​decleaver](https://togithub.com/decleaver) in [defenseunicorns/uds-cli#618 - fix: ensures partial pkgs are correct and adds smoke test to workflows by [@​UncleGedd](https://togithub.com/UncleGedd) in [defenseunicorns/uds-cli#643 - fix: typo in Zarf pkg name and refactor smoke test workflow by [@​UncleGedd](https://togithub.com/UncleGedd) in [defenseunicorns/uds-cli#644 **Full Changelog**: defenseunicorns/uds-cli@v0.10.4...v0.11.0 </details> <details> <summary>defenseunicorns/uds-common (defenseunicorns/uds-common)</summary> ### [`v0.4.5`](https://togithub.com/defenseunicorns/uds-common/releases/tag/v0.4.5) [Compare Source](https://togithub.com/defenseunicorns/uds-common/compare/v0.4.4...v0.4.5) ##### Miscellaneous - **deps:** update support-deps to v0.11.0 ([#​137](https://togithub.com/defenseunicorns/uds-common/issues/137)) ([985dfd7](https://togithub.com/defenseunicorns/uds-common/commit/985dfd7f9d745d07daa528e7dfdc982c61b2da4b)) </details> <details> <summary>github/codeql-action (github/codeql-action)</summary> ### [`v3.25.8`](https://togithub.com/github/codeql-action/compare/v3.25.7...v3.25.8) [Compare Source](https://togithub.com/github/codeql-action/compare/v3.25.7...v3.25.8) ### [`v3.25.7`](https://togithub.com/github/codeql-action/compare/v3.25.6...v3.25.7) [Compare Source](https://togithub.com/github/codeql-action/compare/v3.25.6...v3.25.7) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 7am and before 9am every weekday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/uds-package-gitlab-runner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJzdXBwb3J0LWRlcHMiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Wayne Starr <[email protected]> Co-authored-by: Wayne Starr <[email protected]>
ericwyles
pushed a commit
to defenseunicorns/uds-package-mattermost
that referenced
this pull request
Jun 11, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/dependency-review-action](https://togithub.com/actions/dependency-review-action) | action | patch | `v4.3.2` -> `v4.3.3` | | [defenseunicorns/uds-common](https://togithub.com/defenseunicorns/uds-common) | | minor | `v0.4.5` -> `v0.5.0` | | [defenseunicorns/uds-common](https://togithub.com/defenseunicorns/uds-common) | action | minor | `v0.4.5` -> `v0.5.0` | | [golangci/golangci-lint](https://togithub.com/golangci/golangci-lint) | repository | patch | `v1.59.0` -> `v1.59.1` | | [python-jsonschema/check-jsonschema](https://togithub.com/python-jsonschema/check-jsonschema) | repository | patch | `0.28.4` -> `0.28.5` | | [renovatebot/pre-commit-hooks](https://togithub.com/renovatebot/pre-commit-hooks) | repository | minor | `37.391.0` -> `37.399.9` | | [step-security/harden-runner](https://togithub.com/step-security/harden-runner) | action | patch | `v2.8.0` -> `v2.8.1` | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://togithub.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>actions/dependency-review-action (actions/dependency-review-action)</summary> ### [`v4.3.3`](https://togithub.com/actions/dependency-review-action/releases/tag/v4.3.3): Notes for v4.3.3 [Compare Source](https://togithub.com/actions/dependency-review-action/compare/v4.3.2...v4.3.3) #### What's Changed - Allow slashes in purl package names by [@​juxtin](https://togithub.com/juxtin) in [actions/dependency-review-action#765 - use the v3 version of the deps.dev API by [@​josieang](https://togithub.com/josieang) in [actions/dependency-review-action#741 - PR with suggestions - \[Improvement]: Help streamline / simplify dependency review action README by [@​am-stead](https://togithub.com/am-stead) in [actions/dependency-review-action#773 - fix show-openssf-scorecard-levels input by [@​ramann](https://togithub.com/ramann) in [actions/dependency-review-action#776 - Updates to the contribution guidelines by [@​jonjanego](https://togithub.com/jonjanego) in [actions/dependency-review-action#778 - Create issue templates by [@​jonjanego](https://togithub.com/jonjanego) in [actions/dependency-review-action#777 - Fix the max comment length issue by [@​jhutchings1](https://togithub.com/jhutchings1) and [@​elireisman](https://togithub.com/elireisman) in [actions/dependency-review-action#767 - Bump project version to 4.3.3 in prep for a release by [@​elireisman](https://togithub.com/elireisman) in [actions/dependency-review-action#781 #### New Contributors - [@​josieang](https://togithub.com/josieang) made their first contribution in [actions/dependency-review-action#741 - [@​am-stead](https://togithub.com/am-stead) made their first contribution in [actions/dependency-review-action#773 - [@​ramann](https://togithub.com/ramann) made their first contribution in [actions/dependency-review-action#776 **Full Changelog**: actions/dependency-review-action@v4.3.2...v4.3.3 </details> <details> <summary>defenseunicorns/uds-common (defenseunicorns/uds-common)</summary> ### [`v0.5.0`](https://togithub.com/defenseunicorns/uds-common/releases/tag/v0.5.0) [Compare Source](https://togithub.com/defenseunicorns/uds-common/compare/v0.4.6...v0.5.0) ##### ⚠ BREAKING CHANGES - update publish to take architecture as an input ([#​143](https://togithub.com/defenseunicorns/uds-common/issues/143)) ##### Miscellaneous - update publish to take architecture as an input ([#​143](https://togithub.com/defenseunicorns/uds-common/issues/143)) ([62620f5](https://togithub.com/defenseunicorns/uds-common/commit/62620f59c14c773e5f6f07aaafc70ae34cff36bd)) ### [`v0.4.6`](https://togithub.com/defenseunicorns/uds-common/releases/tag/v0.4.6) [Compare Source](https://togithub.com/defenseunicorns/uds-common/compare/v0.4.5...v0.4.6) ##### Bug Fixes - renovate incorrectly matching oci helm charts for helm datasources ([#​141](https://togithub.com/defenseunicorns/uds-common/issues/141)) ([2761f2a](https://togithub.com/defenseunicorns/uds-common/commit/2761f2a5f69bae3967bb8a9ff6d392007f90a21b)) ##### Miscellaneous - allow debug logs to continue through failure ([#​146](https://togithub.com/defenseunicorns/uds-common/issues/146)) ([bec4fc3](https://togithub.com/defenseunicorns/uds-common/commit/bec4fc330d720673f645bda7e56006218ec96aad)) - **deps:** update uds common support dependencies to v0.22.1 ([#​144](https://togithub.com/defenseunicorns/uds-common/issues/144)) ([d618bd2](https://togithub.com/defenseunicorns/uds-common/commit/d618bd2be3f75d62346594cb8d6d8c339b074f93)) </details> <details> <summary>golangci/golangci-lint (golangci/golangci-lint)</summary> ### [`v1.59.1`](https://togithub.com/golangci/golangci-lint/releases/tag/v1.59.1) [Compare Source](https://togithub.com/golangci/golangci-lint/compare/v1.59.0...v1.59.1) `golangci-lint` is a free and open-source project built by volunteers. If you value it, consider supporting us, the [maintainers](https://opencollective.com/golangci-lint) and [linter authors](https://golangci-lint.run/product/thanks/). We appreciate it! ❤️ For key updates, see the [changelog](https://golangci-lint.run/product/changelog/#​1591). #### Changelog - [`f738736`](https://togithub.com/golangci/golangci-lint/commit/f7387361) build(deps): bump github.com/Antonboom/testifylint from 1.3.0 to 1.3.1 ([#​4759](https://togithub.com/golangci/golangci-lint/issues/4759)) - [`44b3cdd`](https://togithub.com/golangci/golangci-lint/commit/44b3cdd1) build(deps): bump github.com/go-viper/mapstructure/v2 from 2.0.0-alpha.1 to 2.0.0 ([#​4788](https://togithub.com/golangci/golangci-lint/issues/4788)) - [`1a55854`](https://togithub.com/golangci/golangci-lint/commit/1a55854a) build(deps): bump github.com/golangci/misspell from 0.5.1 to 0.6.0 ([#​4804](https://togithub.com/golangci/golangci-lint/issues/4804)) - [`9a7a1ad`](https://togithub.com/golangci/golangci-lint/commit/9a7a1ad4) build(deps): bump github.com/polyfloyd/go-errorlint from 1.5.1 to 1.5.2 ([#​4785](https://togithub.com/golangci/golangci-lint/issues/4785)) - [`aaff918`](https://togithub.com/golangci/golangci-lint/commit/aaff9184) build(deps): bump github.com/sashamelentyev/usestdlibvars from 1.25.0 to 1.26.0 ([#​4801](https://togithub.com/golangci/golangci-lint/issues/4801)) - [`a0d2c83`](https://togithub.com/golangci/golangci-lint/commit/a0d2c830) build(deps): bump github.com/shirou/gopsutil/v3 from 3.24.4 to 3.24.5 ([#​4782](https://togithub.com/golangci/golangci-lint/issues/4782)) - [`2042b1f`](https://togithub.com/golangci/golangci-lint/commit/2042b1f1) build(deps): bump go-simpler.org/sloglint from 0.7.0 to 0.7.1 ([#​4784](https://togithub.com/golangci/golangci-lint/issues/4784)) - [`327a78a`](https://togithub.com/golangci/golangci-lint/commit/327a78a8) build(deps): bump golang.org/x/tools from 0.21.0 to 0.22.0 ([#​4802](https://togithub.com/golangci/golangci-lint/issues/4802)) - [`e1a8055`](https://togithub.com/golangci/golangci-lint/commit/e1a80557) fix: SARIF format require issue column >= 1 ([#​4775](https://togithub.com/golangci/golangci-lint/issues/4775)) - [`88f60c8`](https://togithub.com/golangci/golangci-lint/commit/88f60c8c) fix: gomnd deprecated configuration compatibility ([#​4768](https://togithub.com/golangci/golangci-lint/issues/4768)) - [`8173166`](https://togithub.com/golangci/golangci-lint/commit/81731668) fix: init empty result slice for SARIF printer ([#​4758](https://togithub.com/golangci/golangci-lint/issues/4758)) - [`02740ea`](https://togithub.com/golangci/golangci-lint/commit/02740ea1) intrange: add style preset ([#​4797](https://togithub.com/golangci/golangci-lint/issues/4797)) - [`615b873`](https://togithub.com/golangci/golangci-lint/commit/615b873d) unparam: bump to HEAD ([#​4786](https://togithub.com/golangci/golangci-lint/issues/4786)) </details> <details> <summary>python-jsonschema/check-jsonschema (python-jsonschema/check-jsonschema)</summary> ### [`v0.28.5`](https://togithub.com/python-jsonschema/check-jsonschema/blob/HEAD/CHANGELOG.rst#0285) [Compare Source](https://togithub.com/python-jsonschema/check-jsonschema/compare/0.28.4...0.28.5) - Update vendored schemas: bitbucket-pipelines, dependabot, github-actions, github-workflows, gitlab-ci, readthedocs, renovate (2024-06-10) - Update bitbucket schema to use the option from the intellij-bitbucket-references-plugin . For more details on this decision, see :issue:`440` . Thanks [@​blade2005](https://togithub.com/blade2005) for the PR! (:pr:`442`) </details> <details> <summary>renovatebot/pre-commit-hooks (renovatebot/pre-commit-hooks)</summary> ### [`v37.399.9`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.399.9) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.399.8...37.399.9) See https://github.com/renovatebot/renovate/releases/tag/37.399.9 for more changes ### [`v37.399.8`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.399.8) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.399.6...37.399.8) See https://github.com/renovatebot/renovate/releases/tag/37.399.8 for more changes ### [`v37.399.6`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.399.6) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.399.5...37.399.6) See https://github.com/renovatebot/renovate/releases/tag/37.399.6 for more changes ### [`v37.399.5`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.399.5) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.399.3...37.399.5) See https://github.com/renovatebot/renovate/releases/tag/37.399.5 for more changes ### [`v37.399.3`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.399.3) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.399.0...37.399.3) See https://github.com/renovatebot/renovate/releases/tag/37.399.3 for more changes ### [`v37.399.0`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.399.0) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.398.2...37.399.0) See https://github.com/renovatebot/renovate/releases/tag/37.399.0 for more changes ### [`v37.398.2`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.398.2) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.398.1...37.398.2) See https://github.com/renovatebot/renovate/releases/tag/37.398.2 for more changes ### [`v37.398.1`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.398.1) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.398.0...37.398.1) See https://github.com/renovatebot/renovate/releases/tag/37.398.1 for more changes ### [`v37.398.0`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.398.0) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.397.0...37.398.0) See https://github.com/renovatebot/renovate/releases/tag/37.398.0 for more changes ### [`v37.397.0`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.397.0) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.396.0...37.397.0) See https://github.com/renovatebot/renovate/releases/tag/37.397.0 for more changes ### [`v37.396.0`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.396.0) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.395.0...37.396.0) See https://github.com/renovatebot/renovate/releases/tag/37.396.0 for more changes ### [`v37.395.0`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.395.0) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.393.0...37.395.0) See https://github.com/renovatebot/renovate/releases/tag/37.395.0 for more changes ### [`v37.393.0`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.393.0) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.392.0...37.393.0) See https://github.com/renovatebot/renovate/releases/tag/37.393.0 for more changes ### [`v37.392.0`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.392.0) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.391.3...37.392.0) See https://github.com/renovatebot/renovate/releases/tag/37.392.0 for more changes ### [`v37.391.3`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.391.3) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.391.2...37.391.3) See https://github.com/renovatebot/renovate/releases/tag/37.391.3 for more changes ### [`v37.391.2`](https://togithub.com/renovatebot/pre-commit-hooks/releases/tag/37.391.2) [Compare Source](https://togithub.com/renovatebot/pre-commit-hooks/compare/37.391.0...37.391.2) See https://github.com/renovatebot/renovate/releases/tag/37.391.2 for more changes </details> <details> <summary>step-security/harden-runner (step-security/harden-runner)</summary> ### [`v2.8.1`](https://togithub.com/step-security/harden-runner/releases/tag/v2.8.1) [Compare Source](https://togithub.com/step-security/harden-runner/compare/v2.8.0...v2.8.1) ##### What's Changed - Bug fix: Update isGitHubHosted implementation by [@​varunsh-coder](https://togithub.com/varunsh-coder) in [step-security/harden-runner#425 The previous implementation incorrectly identified large GitHub-hosted runners as self-hosted runners. As a result, harden-runner was not executing on these large GitHub-hosted runners. **Full Changelog**: step-security/harden-runner@v2...v2.8.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/uds-package-mattermost). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODguMSIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJzdXBwb3J0LWRlcHMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into #730 in a demo I was building, so I threw together a quick fix for the issue. Now it'll generate a minimum comment. It's not super elegant (a bit of code duplication), but I was in a hurry to unblock the demo. I don't mind if the team decides to make some tweaks to make this less duplicative.
Fixes #730
