Skip to content

Commit

Permalink
Bump Node, Electron and Notion executable versions
Browse files Browse the repository at this point in the history
  • Loading branch information
acerspyro committed Nov 18, 2024
1 parent 57d1b58 commit dd1324c
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 14 deletions.
18 changes: 12 additions & 6 deletions .github/workflows/notion-repackaged.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ on:
push:
branches: [main]
paths:
- 'notion-repackaged.sh'
- '.github/workflows/notion-repackaged.yml'
- "notion-repackaged.sh"
- ".github/workflows/notion-repackaged.yml"

workflow_dispatch:
inputs: {}
Expand Down Expand Up @@ -110,7 +110,13 @@ jobs:

build-app:
name: Build app
needs: [make-vanilla-sources, make-enhanced-sources, preload-variables, create-release]
needs:
[
make-vanilla-sources,
make-enhanced-sources,
preload-variables,
create-release,
]
runs-on: ${{ matrix.os }}
env:
NOTION_VERSION: ${{ needs.preload-variables.outputs.notion_version }}
Expand All @@ -135,7 +141,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 14
node-version: 22
- name: Retrieve saved sources
uses: actions/download-artifact@v2
with:
Expand All @@ -154,7 +160,7 @@ jobs:
run: npx patch-package
- name: Install electron and electron-builder
working-directory: ${{ matrix.edition }}-src
run: npm install electron@11 electron-builder --save-dev
run: npm install electron@33.2.0 electron-builder --save-dev
- name: Run electron-builder
working-directory: ${{ matrix.edition }}-src
env:
Expand All @@ -176,4 +182,4 @@ jobs:
steps:
- uses: geekyeggo/delete-artifact@v1
with:
name: '${{ matrix.edition }}-sources'
name: "${{ matrix.edition }}-sources"
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14.17.1
22.11.0
6 changes: 3 additions & 3 deletions notion-repackaged.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
#

# Version of the original Notion App installer to repackage
export NOTION_VERSION=2.0.18
export NOTION_VERSION=4.0.0

# Revision of the current version
export NOTION_REPACKAGED_REVISION=1
export NOTION_REPACKAGED_REVISION=1.1

# The md5sum hash of the downloaded .exe for the installer
export NOTION_DOWNLOAD_HASH=31bb8b9d547cb5385b9f04017214a206
export NOTION_DOWNLOAD_HASH=9f9cd21ff2245fc27c2ceef224008720

# The commit of notion-enhancer/desktop to target
export NOTION_ENHANCER_DESKTOP_COMMIT=832db26d2e6a247d9e76847b2de50435fa7c40d2
8 changes: 4 additions & 4 deletions scripts/build-locally.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash
set -e

source `dirname $0`/_utils.sh
source $(dirname $0)/_utils.sh
workdir ${WORKSPACE_BUILD_DIR}

check-cmd jq git
Expand All @@ -26,7 +26,7 @@ if [ ! -d "${NOTION_REPACKAGED_EDITION_SRCDIR}" ]; then
exit -1
fi

pushd "${NOTION_REPACKAGED_EDITION_SRCDIR}" > /dev/null
pushd "${NOTION_REPACKAGED_EDITION_SRCDIR}" >/dev/null

log "Installing dependencies..."
npm install
Expand All @@ -35,10 +35,10 @@ log "Running patch-package"
npx patch-package

log "Install electron and electron-builder..."
npm install electron@11 electron-builder --save-dev
npm install electron@33.2.0 electron-builder --save-dev

log "Running electron-builder..."
node_modules/.bin/electron-builder \
--config $WORKSPACE_DIR/electron-builder.js $@

popd > /dev/null
popd >/dev/null

0 comments on commit dd1324c

Please sign in to comment.