Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(schema.json): Adiciona novos campos de subeventos e oficionas re… #16

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat(schema.json): Adiciona novos campos de subeventos e oficionas re… #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/api/event/content-types/event/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"target": "api::partner.partner",
"inversedBy": "events"
},
"data": {
"data_inicio": {
"required": true,
"type": "date"
},
Expand All @@ -73,6 +73,20 @@
},
"destaque": {
"type": "boolean"
},
"subeventos": {
"type": "relation",
"relation": "oneToMany",
"target": "api::event.event"
},
"data_fim": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tem algum motivo específico para usarmos snake_case ao invés de camelCase? Esses campos são colunas no banco de dados? Se não houver nenhuma restrição, acho que aderir ao camelCase aqui poderia ser uma boa, já que consumimos esses dados diretamente no front-end.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A menos que isso se torne uma coluna no banco de dados, pois o Postgres não lida muito bem com camelCase, aí se esse for o caso, é mais fácil deixar com snake_case mesmo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neste caso, casualmente, usamos snake_case para seguir a convenção do projeto.
Mas pelo que encontrei a partir da versão 4 do Strapi, o padrão é snake_case. (https://docs.strapi.io/dev-docs/migration/v3-to-v4/data/sql#column-name-casing)
Estes campos vão se tornar colunas no banco de dados sim.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seria legal depois ver para padronizar isso então, tornar uma regra pro cms.

"required": true,
"type": "date"
},
"oficinas": {
"type": "relation",
"relation": "oneToMany",
"target": "api::workshop.workshop"
}
}
}