Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

38/pagina detalhe topico #46

Merged
merged 14 commits into from
Sep 6, 2024
Merged

38/pagina detalhe topico #46

merged 14 commits into from
Sep 6, 2024

Conversation

Wander06
Copy link
Contributor

@Wander06 Wander06 commented Sep 2, 2024 •
edited
Loading

#38 - pagina detalhe topico

🆙 CHANGELOG

  • Página com suporte a descrição com ou sem vídeo
  • Tratamento de erro quando não tiver cards de exercício
  • Suporte a markdown
  • Responsivo
  • Página para erro de requisição

⚠️ Me certifico que:

  • Não deixei nenhum novo warning, erro ou console.log nas minhas modificações
  • Fiz deploy para ambiente de teste certificando que o build não quebrou
  • Solicitei code review para 2 pessoas
  • Obtive aprovação de code review e posso fazer merge

⚠️ Como testar:

  • Abrir na branch 38/pagina-detalhe-topico
  • Garantir que esteja atualizada (Git pull)
  • Verificar qualidade do código
  • Acessar conteúdos que não tenham cards para testar tratamento de erro
  • Aplicação não deve conter nenhum erro, warning ou console.log
  • Alteração proposta no card foi implementada

Wander06 and others added 9 commits August 28, 2024 15:02
@Wander06
feat(src/components/PageElements): Criando elementos de pagina para o…
c3a0cfb 
… detalhamento de topico - @Wander06 @Lip29bm @stephanybrazeir0 @EmilyCavalcanti
@Lip29bm
Merge branch '30/componente-descricao-topicos-referencias-exercicios'…
1530fbd 
… of https://github.com/aceleradora-TW/e-acelera-front into 38/pagina-detalhe-topico
@Lip29bm
feat (src/components/Description/DescriptionFull/index.tsx) adiçao do…
bedd739 
… description video @Wander06 @EmilyCavalcanti @stephanybrazeir0 @Lip29bm
@Wander06
Merge branch 'main' of https://github.com/aceleradora-TW/e-acelera-front
9ec4660 
 into 38/pagina-detalhe-topico
@Lip29bm
feat (src/components/Description/DescriptionFull/index.tsx) padroniza…
2d28509 
…cao do espacamento entre paragrafos @Wander06 @EmilyCavalcanti @stephanybrazeir0 @Lip29bm
@Wander06
Merge branch '38/pagina-detalhe-topico' of https://github.com/acelera…
79e943b 
…dora-TW/e-acelera-front into 38/pagina-detalhe-topico
@Wander06
feat(src/components/ButtonCard): Removendo buttonSelect - @Wander06 @…
a38b37e 
…Lip29bm @stephanybrazeir0 @EmilyCavalcanti
@Wander06
feat: Ajustando logica para renderizar video
c07e767
@Wander06
feat(src/components/fetchData src/components/PageElements/Container/C…
e114bea 
…ontainerCardsExercises src/components/PageElements/Renders): Adicionando statusCode na funcao fetchData, criando pagina de badRequest e adicionando componente badRequest nos renders - @Wander06 @Lip29bm @stephanybrazeir0 @EmilyCavalcanti
leonardogomesp

This comment was marked as outdated.

Sign in to view

leonardogomesp
leonardogomesp requested changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@leonardogomesp leonardogomesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logs, textos e legibilidade

src/app/Nivelamento/[detailingTheme]/[detailingTopic]/page.tsx Outdated Show resolved Hide resolved
src/app/Autoestudo/[detailingTheme]/[detailingTopic]/page.tsx Outdated Show resolved Hide resolved
src/components/BadRequest/index.tsx Outdated Show resolved Hide resolved
src/components/BadRequest/index.tsx Outdated Show resolved Hide resolved
src/components/Description/DescriptionWithVideo/index.tsx Outdated Show resolved Hide resolved
src/components/PageElements/Container/ContainerCardsExercises/index.tsx Outdated Show resolved Hide resolved
src/components/PageElements/Container/ContainerCardsExercises/index.tsx Outdated Show resolved Hide resolved
src/components/PageElements/Container/ContainerCardsExercises/index.tsx Outdated Show resolved Hide resolved
src/components/PageElements/Content/DetailingTopicContent/index.tsx Outdated Show resolved Hide resolved
src/components/PageElements/Renders/RenderDetailingTopicPage/index.tsx Outdated Show resolved Hide resolved
leonardogomesp
leonardogomesp requested changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@leonardogomesp leonardogomesp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diferença no package.lock quando comparado a branch main, rodar um npm i deve resolver

stephanybrazeir0 and others added 2 commits September 5, 2024 11:10
@stephanybrazeir0
feat (src/components/Description/DescriptionWithVideo/index.tsx src/c…
1b521ac 
…omponents/PageElements/Container/ContainerCardsExercises/index.tsx src/components/PageElements/Container/ContainerCardsTopics/index.tsx src/components/PageElements/Renders/RenderDetailingTopicPage/index.tsx src/components/BadRequest/index.tsx src/app/Nivelamento/[detailingTheme]/[detailingTopic]/page.tsx) remocacao de console log e espacoes em branco, alteracao na funcao para split e variavel para validacao de dados
@Lip29bm
feat(src/components/PageElements/Container/ContainerCardExercises/ind…
0997562 
…ex.tsx src/components/PageElements/Content/DetailingTopicContent/index.tsx src/app/Autoestudo/[detailingTheme]/[detailingTopic]/page.tsx src/app/Nivelamento/[detailingTheme]/[detailingTopic]/page.tsx) alteracoes solicitadas pelo pr realizadas @stephany @Lip29bm @Emily
leonardogomesp
leonardogomesp requested changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@leonardogomesp leonardogomesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filter e chamada de função

src/components/PageElements/Container/ContainerCardsTopics/index.tsx Show resolved Hide resolved
src/components/PageElements/Content/DetailingTopicContent/index.tsx Outdated Show resolved Hide resolved
leonardogomesp
leonardogomesp reviewed Sep 5, 2024
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
leonardogomesp
leonardogomesp requested changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@leonardogomesp leonardogomesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mover componentes

src/components/PageElements/Content/DetailingThemeContent/index.tsx Outdated Show resolved Hide resolved
src/components/PageElements/Content/DetailingTopicContent/index.tsx Outdated Show resolved Hide resolved
leonardogomesp
leonardogomesp approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@leonardogomesp leonardogomesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leonardogomesp leonardogomesp merged commit 1caf021 into main Sep 6, 2024
1 check passed
@leonardogomesp leonardogomesp deleted the 38/pagina-detalhe-topico branch September 6, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanybrazeir0 stephanybrazeir0 stephanybrazeir0 left review comments

@Lip29bm Lip29bm Lip29bm left review comments

@daniellemadrid daniellemadrid daniellemadrid approved these changes

@leonardogomesp leonardogomesp leonardogomesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Wander06 @daniellemadrid @leonardogomesp @stephanybrazeir0 @Lip29bm