-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MG-2075 - Add guest relation #2228
base: main
Are you sure you want to change the base?
MG-2075 - Add guest relation #2228
Conversation
ef2287b
to
483084a
Compare
users/service.go
Outdated
@@ -113,6 +113,7 @@ func (svc service) IssueToken(ctx context.Context, identity, secret, domainID st | |||
|
|||
token, err := svc.auth.Issue(ctx, &magistrala.IssueReq{UserId: dbUser.ID, DomainId: &d, Type: uint32(auth.AccessKey)}) | |||
if err != nil { | |||
fmt.Println(err.Error()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this log line
a5b8018
to
185a83d
Compare
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
185a83d
to
25b1b39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update SDK godocs
users/service.go
Outdated
@@ -113,6 +113,7 @@ func (svc service) IssueToken(ctx context.Context, identity, secret, domainID st | |||
|
|||
token, err := svc.auth.Issue(ctx, &magistrala.IssueReq{UserId: dbUser.ID, DomainId: &d, Type: uint32(auth.AccessKey)}) | |||
if err != nil { | |||
fmt.Println(err.Error()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove debug statements
@@ -575,6 +575,8 @@ func SwitchToPermission(relation string) string { | |||
return ViewPermission | |||
case MemberRelation: | |||
return MembershipPermission | |||
case GuestRelation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this test too TestSwitchToPermission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also TestCheckRelation
Signed-off-by: nyagamunene <[email protected]>
What type of PR is this?
This is a feature because it adds a policy to a domain member to restrict the creation of new entities such as things, channels and groups in a domain
What does this do?
It adds a guest relation policy to a domain member to restrict the creation of new entities such as things, channels and groups in a domain
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No
Did you document any new/modified feature?
No
Notes