MG-2075 - Add guest relation #2228
Open
+31
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyagamunene
force-pushed
the
MG-2075-PolicyForDomainMemberToRestrictOnCreationNewEntities
branch
2 times, most recently
from
ef2287b
to
483084a
Compare
arvindh123
requested changes
May 20, 2024
users/service.go
Outdated
| @@ -113,6 +113,7 @@ func (svc service) IssueToken(ctx context.Context, identity, secret, domainID st | |||
|
|
|||
| token, err := svc.auth.Issue(ctx, &magistrala.IssueReq{UserId: dbUser.ID, DomainId: &d, Type: uint32(auth.AccessKey)}) | |||
| if err != nil { | |||
| fmt.Println(err.Error()) | |||
nyagamunene
force-pushed
the
MG-2075-PolicyForDomainMemberToRestrictOnCreationNewEntities
branch
2 times, most recently
from
a5b8018
to
185a83d
Compare
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
nyagamunene
force-pushed
the
MG-2075-PolicyForDomainMemberToRestrictOnCreationNewEntities
branch
from
185a83d
to
25b1b39
Compare
arvindh123
previously approved these changes
May 28, 2024
rodneyosodo
requested changes
May 28, 2024
users/service.go
Outdated
| @@ -113,6 +113,7 @@ func (svc service) IssueToken(ctx context.Context, identity, secret, domainID st | |||
|
|
|||
| token, err := svc.auth.Issue(ctx, &magistrala.IssueReq{UserId: dbUser.ID, DomainId: &d, Type: uint32(auth.AccessKey)}) | |||
| if err != nil { | |||
| fmt.Println(err.Error()) | |||
| @@ -575,6 +575,8 @@ func SwitchToPermission(relation string) string { | |||
| return ViewPermission | |||
| case MemberRelation: | |||
| return MembershipPermission | |||
| case GuestRelation: | |||
There was a problem hiding this comment.
Update this test too TestSwitchToPermission
Signed-off-by: nyagamunene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds a policy to a domain member to restrict the creation of new entities such as things, channels and groups in a domain
What does this do?
It adds a guest relation policy to a domain member to restrict the creation of new entities such as things, channels and groups in a domain
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No
Did you document any new/modified feature?
No
Notes