An app to detect licenses from the provided input license text

[lf32]

The aim of this PR is to create a working app inside this Django project to detect licenses from the provided input text and summarize the results for the end user.

[tdruez]

@lf32 That's a good start, see my comments for minor improvements.

In the future you need to provide more context than simply requesting a review.
There's a tons of commented code, which part do you need to be reviewed?
Include what you have accomplished and what is left to do, also include the issues you are facing.

[lf32]

@lf32 That's a good start, see my comments for minor improvements.

In the future you need to provide more context than simply requesting a review. There's a tons of commented code, which part do you need to be reviewed? Include what you have accomplished and what is left to do, also include the issues you are facing.

thanks, i pinged you to let you know about the PR

• the scancode.api.get_licenses accepts files as input but not text, what do you think of it?
• do you think the input text should be stored as a file and then pass it as the argument?

[tdruez]

You can use a tempfile for now or adapt the code to use match with the query_string argument?

Still checking this! will let you know ASAP

[tdruez]

You are putting side by side a form submit button "Scan License" and a navigation link "New Project".

I think the "New Project" as no need to be present in that view.
Also, the action button "Scan License" would make more sense to be located after the form, not on top of it.
The textarea is simply too big, reduce the height.

[lf32]

@tdruez please suggest changes and also any resource for recommending license?

[lf32]

You are putting side by side a form submit button "Scan License" and a navigation link "New Project".

I think the "New Project" as no need to be present in that view. Also, the action button "Scan License" would make more sense to be located after the form, not on top of it. The textarea is simply too big, reduce the height.

How is this?
rows are set to 25, isn't it ok?

[tdruez]

please suggest changes

This looks awesome but where is the code? No code, no review possible.

any resource for recommending license?

I don't know what you mean by that.

[lf32]

This looks awesome but where is the code? No code, no review possible.

I have just pushed changes over here

[tdruez]

@lf32 that's a great start, see my comments for minor improvements.

I think the UI is fine for now, you should focus on the views code to make it working on real input text.

[tdruez]

@lf32 please read the following for future commit messages (no need to update the existing ones): https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html

For example: "changed card title from name to short_name" should be "Change card title from name to short_name #450"

You can look at the commit history of the repo and try to follow the conventions in place.

[tdruez]

Hi @lf32 what's the latest status on this PR?

[lf32]

@tdruez I am writing the tests.

[lf32]

• write unit tests
• set a fixed width for the dropdown
• add navigation with prev and next licenses

[tdruez]

@lf32 Thanks for the update!

[DennisClark]

per @pombredanne we need to determine if this properly belongs in ScanCode.io or in a separate application. The design-to-date is a separate app.

[lf32]

@AyanSinhaMahapatra, I have added a utilities dropdown and moved scan tab to Detect License which redirects to /scantext/.

[tdruez]

Hi @lf32 what's the latest status on this PR? Is it feature complete?

[lf32]

@tdruez I have discussed with philippe about it and still needs changes to be made.

[tdruez]

@lf32 Can you provide a list of those changes?

[lf32]

• writing more tests
• code correction
• migrating to scancode-toolkit v32.0.1 in scantext
• more efficient user interface