Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SCTK #1409

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Update SCTK #1409

wants to merge 7 commits into from

Conversation

AyanSinhaMahapatra
Copy link
Member

No description provided.

JonoYang and others added 7 commits October 16, 2024 16:09
@JonoYang
Use branch of sctk for yarn.lock parsing updates
42d3a35 
Signed-off-by: Jono Yang <[email protected]>
@JonoYang
Use updated commit for npm package assignment fix
5a51b26 
Signed-off-by: Jono Yang <[email protected]>
@JonoYang
Increase purldb default timeout
3763cd4 
Signed-off-by: Jono Yang <[email protected]>
@JonoYang
Do not run package assembly step in inspect_packages
8e762b0 
    * Increase purldb timeout

Signed-off-by: Jono Yang <[email protected]>
@JonoYang
Use sctk with npm package-lock.json fixes
3dd8f61 
Signed-off-by: Jono Yang <[email protected]>
@AyanSinhaMahapatra
Restructure the inspect_packages pipeline
f56c5cf 
Statically resolve dependencies only in the resolve_dependencies
pipeline, and inspect_packages is used for a fast scan to only get
packages/dependecies.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Update SCTK to latest release v32.3.0
2fe00f6 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@tdruez
Copy link
Contributor

tdruez commented Oct 29, 2024

Hi @AyanSinhaMahapatra, what's the status on this one? Any particular reason the upgrade is problematic?
It also seems that changes unrelated to the sctk upgrade are present, shouldn't those be handled separatly?

@AyanSinhaMahapatra
Copy link
Member Author

@tdruez this makes more sense, creating a new PR at #1418 to just update Scancode-toolkit to the latest version, opened a new issue with the rest of the changes we wanted to do here: #1419, will tackle this separately in this PR.

@tdruez
Copy link
Contributor

tdruez commented Oct 31, 2024

@AyanSinhaMahapatra Following the merge of #1418, should we close this one?

@AyanSinhaMahapatra
Copy link
Member Author

@tdruez no, because we still need to address #1419 through this, I will update the PR accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyanSinhaMahapatra @tdruez @JonoYang