Skip to content

Add support for buildpack.toml files #4031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Add support for buildpack.toml files #4031

wants to merge 10 commits into from

Conversation

NucleonGodX
Copy link
Contributor

@NucleonGodX NucleonGodX commented Dec 19, 2024 •
edited
Loading

Fixes #3477

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Signed-off-by: NucleonGodX [email protected]

@NucleonGodX NucleonGodX marked this pull request as draft December 19, 2024 07:18
@NucleonGodX NucleonGodX marked this pull request as ready for review December 23, 2024 09:37
@NucleonGodX NucleonGodX marked this pull request as draft December 24, 2024 04:52
@NucleonGodX NucleonGodX marked this pull request as ready for review December 24, 2024 13:55
@NucleonGodX NucleonGodX changed the title Added support for buildpack.toml files Add support for buildpack.toml files Dec 31, 2024
AyanSinhaMahapatra
AyanSinhaMahapatra requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks++ @NucleonGodX for the PR!
This is a great start.
See my comments for your consideration.

@NucleonGodX
Copy link
Contributor Author

Thanks @AyanSinhaMahapatra for your suggestions, I've implemented them.

@NucleonGodX
add header
b99f789 
Signed-off-by: NucleonGodX <[email protected]>
AyanSinhaMahapatra
AyanSinhaMahapatra requested changes Apr 25, 2025
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NucleonGodX thanks++ for your changes, see comments for some more improvements, and this should be ready to merge after.

@NucleonGodX
Copy link
Contributor Author

Hey @AyanSinhaMahapatra, thanks for your suggestions, I will apply them in a few days.

@NucleonGodX
suggestions applied
6a38f0e 
Signed-off-by: NucleonGodX <[email protected]>
@NucleonGodX
Copy link
Contributor Author

@AyanSinhaMahapatra I've applied almost all your suggestions, a few are left that I'll apply by tomorrow.

@NucleonGodX
Copy link
Contributor Author

Applied All suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra AyanSinhaMahapatra requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for buildpack.toml manifest
2 participants
@NucleonGodX @AyanSinhaMahapatra