Skip to content

Conversation

@mschristensen
Copy link
Contributor

@mschristensen mschristensen commented Apr 28, 2025

Description

Adds a set of concepts pages to the LiveObjects docs to explain the key concepts you need to understand when working with LiveObjects.

Adds usage docs for working with the REST API to the "advanced" section. This material is partly drawn from #2513 and will allow us to remove the additional contextual information in those reference docs and make more appropriate use of the Open API spec.

I'm not planning to add a "quickstart" guide for LiveObjects just yet, preferring to wait until we have a REST SDK.

Checklist

@mschristensen mschristensen requested a review from VeskeR April 28, 2025 16:25
@coderabbitai
Copy link

coderabbitai bot commented Apr 28, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@GregHolmes GregHolmes temporarily deployed to ably-docs-feature-pub-1-etahqe April 29, 2025 08:27 Inactive
Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great addition to the LiveObjects docs, thank you!
A few comments for fixes and improvements.

Note that I did a quick read through of the rest-api-usage page as I expect the endpoints, json bodies and overall content was already checked in previous REST API docs PRs.

Also, #2513 (rest api docs to Open API) just got merged. Does it change anything for this PR?

Rename LiveObjects Features to Object Types, since each menu item
corresponds to a LiveObjects data type.
@mschristensen mschristensen force-pushed the feature/PUB-1614-live-objects-rest-api branch from 20cf116 to c0f8a10 Compare April 30, 2025 11:24
@mschristensen
Copy link
Contributor Author

Thanks for the review @VeskeR, I have made those changes. I will review the reference docs changes separately and check they align with this.

@mschristensen mschristensen requested a review from VeskeR April 30, 2025 12:01
@VeskeR
Copy link
Contributor

VeskeR commented Apr 30, 2025

Are fixup! commits autosquashed on merge? Doesn't seem like github has this functionality by default.
If not, might want to fixup them manually

Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good 👍

A minor comment above ^ about fixup! commits

@mschristensen
Copy link
Contributor Author

Are fixup! commits autosquashed on merge? Doesn't seem like github has this functionality by default. If not, might want to fixup them manually

Yep don't worry, I tend to squash after approval so I can link the SHAs in comments for review purposes.

(I wish GH would add this feature)

All done :)

@mschristensen mschristensen force-pushed the feature/PUB-1614-live-objects-rest-api branch from dbed0bb to e229600 Compare April 30, 2025 12:41
@mschristensen mschristensen merged commit c57fc91 into integration/liveobjects Apr 30, 2025
1 of 2 checks passed
@mschristensen mschristensen deleted the feature/PUB-1614-live-objects-rest-api branch April 30, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants