-
Notifications
You must be signed in to change notification settings - Fork 45
Feature/pub 1614 live objects rest api #2561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pub 1614 live objects rest api #2561
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great addition to the LiveObjects docs, thank you!
A few comments for fixes and improvements.
Note that I did a quick read through of the rest-api-usage page as I expect the endpoints, json bodies and overall content was already checked in previous REST API docs PRs.
Also, #2513 (rest api docs to Open API) just got merged. Does it change anything for this PR?
Rename LiveObjects Features to Object Types, since each menu item corresponds to a LiveObjects data type.
20cf116 to
c0f8a10
Compare
|
Thanks for the review @VeskeR, I have made those changes. I will review the reference docs changes separately and check they align with this. |
|
Are |
VeskeR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking good 👍
A minor comment above ^ about fixup! commits
Yep don't worry, I tend to squash after approval so I can link the SHAs in comments for review purposes. (I wish GH would add this feature) All done :) |
Replaces references to /docs/liveobjects/quickstart#step-4 with /docs/liveobjects/concepts/objects#root-object
dbed0bb to
e229600
Compare
Description
Adds a set of concepts pages to the LiveObjects docs to explain the key concepts you need to understand when working with LiveObjects.
Adds usage docs for working with the REST API to the "advanced" section. This material is partly drawn from #2513 and will allow us to remove the additional contextual information in those reference docs and make more appropriate use of the Open API spec.
I'm not planning to add a "quickstart" guide for LiveObjects just yet, preferring to wait until we have a REST SDK.
Checklist