[REA-1702] feat: web push #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
owenpearson
commented
May 22, 2024
owenpearson
commented
- adds a plugin which enables clients to be activated for receipt of push notifications.
- adds support for w3c push transport to web clients.
- adds push channel transport for testing push activation on all platforms.
github-actions
bot
temporarily deployed
to
staging/pull/1775/bundle-report
owenpearson
force-pushed
the
push-activation-v2
branch
from
df841d6
to
9175832
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1775/bundle-report
ttypic
requested changes
May 30, 2024
owenpearson
force-pushed
the
push-activation-v2
branch
from
9175832
to
05af39c
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1775/bundle-report
owenpearson
force-pushed
the
push-activation-v2
branch
from
05af39c
to
6970b80
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1775/bundle-report
owenpearson
force-pushed
the
push-activation-v2
branch
from
6970b80
to
934a818
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1775/bundle-report
VeskeR
requested changes
Jun 14, 2024
There was a problem hiding this comment.
Have a wall of comments but mostly they are structural suggestions.
Couple of things that I couldn't attach to code lines:
- Should we add new Push plugin to
scripts/moduleReport.tspluginNameslist? I imagine we would need to updategetBundleInfoin there, as currently it always imports from'./build/modular/index.mjs'. - Per RSH7 both
RestChannelandRealtimeChannelshould havepushobject. Why did we addpushonly toRestChannelhere?
P.S. sorry for the amount of comments 😬 I wonder if we could've done it in separate PRs for web push integration branch.
owenpearson
force-pushed
the
push-activation-v2
branch
from
934a818
to
7a2eb66
Compare
owenpearson
force-pushed
the
push-activation-v2
branch
from
7a2eb66
to
88389e4
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1775/bundle-report
owenpearson
force-pushed
the
push-activation-v2
branch
from
88389e4
to
c4eaecc
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1775/bundle-report
owenpearson
force-pushed
the
push-activation-v2
branch
from
0970797
to
6e81e7e
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1775/bundle-report
owenpearson
force-pushed
the
push-activation-v2
branch
from
6e81e7e
to
c481002
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1775/bundle-report
4 tasks
VeskeR
requested changes
Jun 24, 2024
owenpearson
force-pushed
the
push-activation-v2
branch
from
c481002
to
20778ff
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1775/bundle-report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.