Document IXHRRequest’s emitted events #1574
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to understand them for something I was investigating, thought it
worth documenting my findings.
Also made the arg types consistent between those expected by
CometTransport and those emitted by the XHR implementations.
TODO still a bit wip — need to double check the params to all of the
on('complete') and on('data'), and also switch to IPartialErrorInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to understand them for something I was investigating, thought it worth documenting my findings.
Also made the arg types consistent between those expected by CometTransport and those emitted by the XHR implementations.
TODO still a bit wip — need to double check the params to all of the on('complete') and on('data'), and also switch to IPartialErrorInfo