Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout compatibility using event.key #7

Closed
wants to merge 3 commits into from
Closed

Layout compatibility using event.key #7

wants to merge 3 commits into from

Conversation

Razboi
Copy link

@Razboi Razboi commented Jul 16, 2018

Using event.keyCode limits the keyboard layout compatibility. Added a trigger.key property for triggering with event.key

@Razboi
Copy link
Author

Razboi commented Jul 16, 2018

Ops. Messed up building for my own project. It's reverted now

Teippo2020
Teippo2020 reviewed Jul 12, 2019
View reviewed changes
Copy link

@Teippo2020 Teippo2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome feature!

Teippo2020
Teippo2020 approved these changes Jul 12, 2019
View reviewed changes
Copy link

@Teippo2020 Teippo2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome feature!

@Teippo2020
Copy link

To the maintainer, are there any plans to merge this feature? The library basically doesn't work on MAC for the character @

@abinavseelan
Copy link
Owner

Apologises for not getting back to this earlier. 😞 Thank you so much for raising this fix @Razboi 🙂

Since this is a breaking change, can we assimilate this change into https://github.com/abinavseelan/react-input-trigger/tree/pre-release/2.0.0. This branch has some more breaking changes that fix non-standard input elements as highlighted in #10 and would be the next major version release for this package.

@Teippo2020
Copy link

That would be awesome! In the meantime (because I needed this feature so much) I created a fork and published it to npm, just in case anyone needs this feature before the release.

https://www.npmjs.com/package/react-input-trigger-fork

@Razboi Razboi closed this by deleting the head repository Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teippo2020 Teippo2020 Teippo2020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Razboi @Teippo2020 @abinavseelan