Fix: Ref handling for wider support #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rheaditi
force-pushed
the
bugfix/broken-ref
branch
from
f0d2fe7 to
4d38bc0
Compare
Only fetch ref when required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Ref handling for wider support
Change the way
react-input-triggerreceives/sets the ref to theinputortextareacomponent.This change is introduced [after #10, #12] in order to offer wider support to projects using component libraries for their form input fields.
What changes
It's now mandatory for the consumer of
react-input-triggerto pass the ref to the underlying input component - as opposed toreact-input-triggercloning the children and setting the ref.Additional benefits