-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update io.py to add no_basic_shapes option #247
Open
vmario89
wants to merge
5
commits into
abey79:master
Choose a base branch
from
vmario89:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added option in write_svg to write svg:path instead of svg:line, svg:polyline and svg:polygon. You need to set no_basic_shapes to True to write svg:path elements. Else the default behaviour writing basic elements is kept
abey79
requested changes
Apr 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! There are a few change that would be needed before it can merged, though:
- The essence of this feature is to reduce inkscape loading time. This should be benchmarked, but I think a single, monolithic
<path>
with multipleM
commands would be faster than multiple<path>
commands - See my comments in the code.
- Optionally, this PR would include an update to the
write
command to expose thesingle_path
parameter. I can also deal with that in a separate PR too. - Tests should be added and obviously linting should be fixed.
More refactoring required ...
Code looks not so nice i think, but it works at least as exspected.
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option in write_svg to write svg:path instead of svg:line, svg:polyline and svg:polygon. You need to set no_basic_shapes to True to write svg:path elements. Else the default behaviour writing basic elements is kept
Description
to be completed
Checklist
black
andisort
)mypy vpype vpype_cli tests
returns no errorpytest
succeedshelp
make clean && make html
indocs/
)