Fix: add missing exit_stack.close() to end of /v1/completions endpoint#1795
Closed
gjpower wants to merge 1 commit intoabetlen:mainfrom
Closed
Fix: add missing exit_stack.close() to end of /v1/completions endpoint#1795gjpower wants to merge 1 commit intoabetlen:mainfrom
gjpower wants to merge 1 commit intoabetlen:mainfrom
Conversation
Contributor
Author
|
#1798 supersedes this MR as I found thread starvation issue was not just due to improper closing of exit_stack but due to thread starvation from dependency pull of llama_proxy locking all worker threads |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing the llama proxy lock to be retained until exit_stack is cleaned up by garbage collector