Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #215

Open
wants to merge 30 commits into
base: ver-2.4.1
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
464596f
remove unused resource files
zafodB Aug 18, 2021
e126085
fix a bunch of typos in code and comments
zafodB Aug 18, 2021
c1c22c3
remove unused namespace declarations
zafodB Aug 18, 2021
1241a38
formatting, java style and logic changes, according to IDE code inspe…
zafodB Aug 18, 2021
6d5b4c1
second set of java style and logic changes
zafodB Aug 18, 2021
b972a3e
delete a bunch of unused iptables code
zafodB Aug 18, 2021
e2038a7
Android Style and correctness changes as proposed by IDE
zafodB Aug 18, 2021
7418180
delete unused method
zafodB Aug 18, 2021
a72aa3f
delete unused file api_keys.xml
zafodB Aug 18, 2021
8713a12
Merge branch 'ver-2.4(major)' into code-cleanup
zafodB Aug 18, 2021
445fd75
update gradle version to 7.1 and bump several library versions to lat…
zafodB Aug 18, 2021
e223f3f
remove unneeded files in root directory
zafodB Aug 24, 2021
1e3b21e
code formatting
zafodB Aug 25, 2021
7c214c3
remove colon from string resource
zafodB Aug 25, 2021
b963230
remove redundant "this" keyword
zafodB Aug 25, 2021
d6a2f11
adjust strings in RecordOverviewFragment and StatisticsFragment
zafodB Aug 25, 2021
7843435
remove unused string resources
zafodB Aug 25, 2021
fa5339c
Merge branch 'ver-2.4(major)' into code-cleanup
zafodB Aug 25, 2021
c939f8d
remove overlooked merge conflict artefacts
zafodB Aug 25, 2021
825eff1
Merge branch 'ver-2.4(major)' into code-cleanup
zafodB Aug 25, 2021
4a38d50
Merge branch 'ver-2.4(major)' into code-cleanup
zafodB Aug 30, 2021
ea6ba2d
fix background location being requested twice
zafodB Aug 30, 2021
6b2f73e
temporarily disable backups
zafodB Aug 30, 2021
7e3bd93
bump dependency versions to latest available
zafodB Sep 1, 2021
9eb3c5e
delete unused code
zafodB Sep 1, 2021
f8e40bc
fully migrate away from jcenter and replace an unsupported dependency
zafodB Sep 1, 2021
e7e5e2c
bump lib versions and minor fixes
zafodB Sep 1, 2021
106fdc0
adjust gitignore
zafodB Sep 1, 2021
4b7d3f9
remove unused file
zafodB Sep 1, 2021
1719c13
increment gradle version
zafodB Sep 2, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ native/build.o
/javadoc.xml
/doc
/greenDaoGenerator/
release/
19 changes: 0 additions & 19 deletions NOTES.md

This file was deleted.

89 changes: 33 additions & 56 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,13 @@ buildscript {
mavenCentral()
google()

// jcenter reached end-of-life, but is required for MQTT until migrated.
jcenter()

}
dependencies {
classpath 'com.android.tools.build:gradle:7.0.0'
classpath 'com.android.tools.build:gradle:7.0.2'
classpath 'org.greenrobot:greendao-gradle-plugin:3.3.0' // add plugin

classpath 'com.google.gms:google-services:4.3.8' //added gms support
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.7.0'
classpath 'com.google.gms:google-services:4.3.10' //added gms support
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.7.1'
}
}
apply plugin: 'com.android.application'
Expand All @@ -24,25 +21,25 @@ allprojects {
repositories {
mavenCentral()
google()
jcenter()

maven { url "https://jitpack.io" }
}
}

dependencies {
//firebase
implementation 'com.google.firebase:firebase-crashlytics:18.0.1'
implementation 'com.google.firebase:firebase-analytics:19.0.0'
implementation 'com.google.firebase:firebase-core:19.0.0'
implementation 'com.google.firebase:firebase-crashlytics:18.2.1'
implementation 'com.google.firebase:firebase-analytics:19.0.1'
implementation 'com.google.firebase:firebase-core:19.0.1'
//google api
implementation 'com.google.android.gms:play-services-base:17.6.0'
implementation 'com.google.android.gms:play-services-basement:17.6.0'
implementation 'com.google.android.gms:play-services-tasks:17.2.1'
implementation 'com.google.android.gms:play-services-location:18.0.0'

implementation 'com.google.android.gms:play-services-analytics:17.0.0'
implementation 'com.google.android.gms:play-services-analytics:17.0.1'
implementation 'com.google.android.gms:play-services-maps:17.0.1'
implementation 'com.google.android.gms:play-services-auth:19.0.0'
implementation 'com.google.android.gms:play-services-auth:19.2.0'
//greenDao
// implementation 'org.roboguice:roboguice:4.0.0'
implementation 'org.greenrobot:greendao:3.3.0'
Expand All @@ -55,19 +52,19 @@ dependencies {

//AMQP
// https://mvnrepository.com/artifact/com.rabbitmq/amqp-client
implementation group: 'com.rabbitmq', name: 'amqp-client', version: '5.12.0'
implementation group: 'com.rabbitmq', name: 'amqp-client', version: '5.13.1'

implementation files('libs/qpid-broker-core-9.0.0-SNAPSHOT.jar')
//forked repo https://github.com/irinil/qpid-broker-j
//implementation group: 'org.apache.qpid', name: 'qpid-broker-core', version: '8.0.0' //default package doesn't support android.
// https://mvnrepository.com/artifact/javax.naming/jndi
implementation files('libs/jndi-1.2.1.jar');
implementation files('libs/jndi-1.2.1.jar')
// https://mvnrepository.com/artifact/org.apache.qpid/qpid-broker-plugins-amqp-0-8-protocol
implementation group: 'org.apache.qpid', name: 'qpid-broker-plugins-amqp-0-8-protocol', version: '8.0.4'
implementation group: 'org.apache.qpid', name: 'qpid-broker-plugins-amqp-0-8-protocol', version: '8.0.6'
// https://mvnrepository.com/artifact/org.apache.qpid/qpid-broker-plugins-amqp-1-0-protocol
implementation group: 'org.apache.qpid', name: 'qpid-broker-plugins-amqp-1-0-protocol', version: '8.0.4'
implementation group: 'org.apache.qpid', name: 'qpid-broker-plugins-amqp-1-0-protocol', version: '8.0.6'
// https://mvnrepository.com/artifact/org.apache.qpid/qpid-broker-plugins-memory-store
implementation group: 'org.apache.qpid', name: 'qpid-broker-plugins-memory-store', version: '8.0.4'
implementation group: 'org.apache.qpid', name: 'qpid-broker-plugins-memory-store', version: '8.0.6'

//dependencies of AMQP broker
// https://mvnrepository.com/artifact/com.google.guava/guava
Expand All @@ -82,12 +79,12 @@ dependencies {

//MQTT
//moquette
implementation 'io.moquette:moquette-broker:0.12.1'
implementation 'io.moquette:moquette-broker:0.15'
//hive-Mq
implementation group: 'com.hivemq', name: 'hivemq-mqtt-client', version: '1.2.2'

//SU Library for root
implementation 'eu.chainfire:libsuperuser:1.0.0.201704021214'
implementation "com.github.topjohnwu.libsu:core:3.1.2"

//RootTools Library
implementation 'com.github.Stericson:RootShell:1.6'
Expand All @@ -97,9 +94,9 @@ dependencies {
exclude group: 'com.github.Stericson'
}

implementation "androidx.constraintlayout:constraintlayout:2.0.4"
implementation "androidx.constraintlayout:constraintlayout:2.1.0"

implementation "androidx.work:work-runtime:2.6.0-beta01"
implementation 'androidx.work:work-runtime:2.7.0-alpha05'

//androidX legacy support
implementation 'androidx.legacy:legacy-support-v4:1.0.0'
Expand All @@ -110,14 +107,14 @@ dependencies {
implementation files('libs/alfresco-jlan.jar')
implementation files('libs/nineoldandroids-2.4.0.jar')
implementation files('libs/cryptix-jce-provider.jar')
implementation group: 'org.snmp4j', name: 'snmp4j', version: '3.4.5'
implementation group: 'org.snmp4j', name: 'snmp4j', version: '3.5.1'
// https://mvnrepository.com/artifact/org.snmp4j/snmp4j-agent
implementation group: 'org.snmp4j', name: 'snmp4j-agent', version: '3.3.6'
implementation group: 'org.snmp4j', name: 'snmp4j-agent', version: '3.5.0'
implementation files('libs/VirusTotalAPI.jar')
implementation 'com.google.firebase:firebase-analytics:19.0.0'
implementation 'com.google.firebase:firebase-analytics:19.0.1'

// https://mvnrepository.com/artifact/com.hierynomus/smbj
testImplementation group: 'com.hierynomus', name: 'smbj', version: '0.11.1'
testImplementation group: 'com.hierynomus', name: 'smbj', version: '0.11.3'

// https://mvnrepository.com/artifact/commons-io/commons-io
implementation group: 'commons-io', name: 'commons-io', version: '2.9.0'
Expand All @@ -126,7 +123,7 @@ dependencies {
implementation 'com.jaredrummler:android-device-names:2.0.0'

//materialDesign
implementation 'com.google.android.material:material:1.4.0-rc01'
implementation 'com.google.android.material:material:1.5.0-alpha02'

//leakcanary
//debugImplementation 'com.squareup.leakcanary:leakcanary-android:2.4'
Expand All @@ -136,22 +133,22 @@ dependencies {
//testImplementation 'androidx.test:core:1.2.0'

// Optional -- Mockito framework
testImplementation "org.mockito:mockito-core:3.10.0"
implementation 'androidx.annotation:annotation:1.0.0'
testImplementation 'org.mockito:mockito-core:3.12.4'
implementation 'androidx.annotation:annotation:1.2.0'

androidTestImplementation 'androidx.test:rules:1.4.0-beta02'
androidTestImplementation 'androidx.test:runner:1.4.0-beta02'
androidTestImplementation 'androidx.test:rules:1.4.0'
androidTestImplementation 'androidx.test:runner:1.4.0'

// Optional -- UI testing with Espresso
androidTestImplementation 'androidx.test.espresso:espresso-core:3.3.0'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
//PowerMock
testImplementation 'org.powermock:powermock-api-mockito2:2.0.9'
testImplementation 'org.powermock:powermock-module-junit4:2.0.9'
testImplementation 'org.powermock:powermock-core:2.0.9'
testImplementation 'org.powermock:powermock-module-junit4-rule:2.0.9'
implementation 'androidx.multidex:multidex:2.0.0'
implementation 'androidx.multidex:multidex:2.0.1'
// Optional -- Robolectric environment
testImplementation 'org.robolectric:robolectric:4.4.1'
testImplementation 'org.robolectric:robolectric:4.6.1'
}

greendao {
Expand All @@ -169,8 +166,8 @@ configurations {
android {
compileSdkVersion 30
defaultConfig {
versionCode 16
versionName "2.4"
versionCode 17
versionName "2.4.1"
minSdkVersion 24
targetSdkVersion 30
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
Expand Down Expand Up @@ -203,32 +200,12 @@ android {
pickFirst "META-INF/INDEX.LIST"
pickFirst "META-INF/io.netty.versions.properties"
}
// signing for release only works in the console
boolean doSigningForRelease = System.console() != null
if (doSigningForRelease) {
signingConfigs {
release {
storeFile file(System.console().readLine("\n\$ Enter keystore path: "))
storePassword System.console().readLine("\n\$ Enter keystore password: ")
keyAlias System.console().readLine("\n\$ Enter key alias: ")
keyPassword System.console().readLine("\n\$ Enter key password:")
}
}
}

buildTypes {
debug {
debuggable true
jniDebuggable true
// testCoverageEnabled true
//resValue "string", "google_maps_api_key", "AIzaSyDs3xp1-2KQojns5h7mWHHdQxAL-5AZ-q4"
}
if (doSigningForRelease) {
release {
debuggable false
jniDebuggable false
signingConfig signingConfigs.release
//resValue "string", "google_maps_api_key", "AIzaSyDs3xp1-2KQojns5h7mWHHdQxAL-5AZ-q4"
}
}
release {
// signingConfig signingConfigs.config
Expand Down
4 changes: 0 additions & 4 deletions lint.xml

This file was deleted.

82 changes: 0 additions & 82 deletions pom.xml~

This file was deleted.

20 changes: 0 additions & 20 deletions proguard-project.txt

This file was deleted.

18 changes: 0 additions & 18 deletions release/output-metadata.json

This file was deleted.

Loading