OID4VCI: Credential Scheme mapping refactorings #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesusMcCloud
approved these changes
Jul 1, 2025
Comment on lines
+118
to
+119
| .associate { | ||
| it.key to it.value |
There was a problem hiding this comment.
.associate { (key, value) -> key to value?
There was a problem hiding this comment.
don't see the increased readability here
| } else { | ||
| throw InvalidToken("neither credential_identifier nor credential_configuration_id set") | ||
| } | ||
|
|
||
| return result.userInfoExtended!! | ||
| return accessToken.userInfoExtended!! |
There was a problem hiding this comment.
this may throw a nullpointer instead of an invalid token
nodh
force-pushed
the
feature/oid4vci-refactorings
branch
from
9d25ed9 to
7c4ea65
Compare
nodh
force-pushed
the
feature/oid4vci-credentialscheme-refactoring
branch
2 times, most recently
from
552ce7d to
d0ae686
Compare
nodh
force-pushed
the
feature/oid4vci-refactorings
branch
from
7c4ea65 to
07df08d
Compare
nodh
force-pushed
the
feature/oid4vci-credentialscheme-refactoring
branch
from
d0ae686 to
a3bd86d
Compare
nodh
force-pushed
the
feature/oid4vci-refactorings
branch
from
07df08d to
9be6b3d
Compare
nodh
force-pushed
the
feature/oid4vci-credentialscheme-refactoring
branch
from
a3bd86d to
df11ebf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.