Fix: Instead of switch "( $max_aspect_ratio )" use a formula for recalculation aspect ratio on Timeline page #4312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe there is a better way. This was done to center the video I think... it was a long time ago. Maybe a fresh approach to layout could do away with it. |
|
Can be done like on Montage page using gridstack.js |
|
I looked at the Timeline page code. |
…tion (timeline.css.php) round(100/$max_aspect_ratio, 2)
IgorA100
changed the title
|
@connortechnology |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, we need to somehow calculate the values through a formula.
But I still haven't figured out which formula to use....