Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new control script #3195

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

therealmichaelberna
Copy link

The netcat control script wasn't working for some of the ONVIF PTZ cameras that I was testing, so I made this one. It uses the same structure as commands issued by ONVIF Device Manager, so if your camera works with ONVIF device manager, it will probably work with this.

The netcat control script wasn't working for some of the ONVIF PTZ cameras that I was testing, so I made this one. It uses the same structure as commands issued by ONVIF Device Manager, so if your camera works with ONVIF device manager, it will probably work with this.
@knight-of-ni
Copy link
Member

Thanks for the contribution, but for this to be useful to the average user we also need the sql that goes with it.
Use zmcamtool.pl to export the relevant sql from your system, then add it to this PR in the dbcreation file here:
https://github.com/ZoneMinder/zoneminder/blob/master/db/zm_create.sql.in#L923

@knight-of-ni knight-of-ni added the more-information-needed More information requested from the original author of this issue label Mar 27, 2021
"Thanks for the contribution, but for this to be useful to the average user we also need the sql that goes with it.
Use zmcamtool.pl to export the relevant sql from your system, then add it to this PR in the dbcreation file here:
https://github.com/ZoneMinder/zoneminder/blob/master/db/zm_create.sql.in#L923"
@therealmichaelberna
Copy link
Author

@knight-of-ni
Thanks Andrew. I added that now.

@therealmichaelberna
Copy link
Author

@knight-of-ni
Let me know if anything else is needed on my end and if I did this properly.

@connortechnology
Copy link
Member

Thanks for your efforts... however... look we have at least 3 or 4 onvif scripts, half of which aren't even onvif. We were trying to clean them up, and now we have yours as well, with no information on which is better and why. It is all way too condusing to anyone out there trying to actually use any of them.

I'm not inclined to merge this at this time. I'd like to see some discussion as to the merits and approach. Also instead of just adding another script, how about patches to the existing onvif script in small chunks that we can actually read and understand in small bytes.

Otherwise we will have to wait until after releasing 1.36.

@therealmichaelberna
Copy link
Author

Thanks for your efforts... however... look we have at least 3 or 4 onvif scripts, half of which aren't even onvif. We were trying to clean them up, and now we have yours as well, with no information on which is better and why. It is all way too condusing to anyone out there trying to actually use any of them.

I'm not inclined to merge this at this time. I'd like to see some discussion as to the merits and approach. Also instead of just adding another script, how about patches to the existing onvif script in small chunks that we can actually read and understand in small bytes.

Otherwise we will have to wait until after releasing 1.36.

This one is based off of the SOAP commands.

https://www.onvif.org/wp-content/uploads/2016/12/ONVIF_WG-APG-Application_Programmers_Guide-1.pdf

As to why it is better, it worked for some Chinese onvif cameras that I was trying to use when the other scripts wouldn't. I believe that this is in accord with the official ONVIF standard since ONVIF says they use soap on the PDF guide above.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed More information requested from the original author of this issue Not Ready for Merge stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants