Fix birthdate conversion issue in EFDG11 #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Malaysia's passport, parsing the birthdate in EFDG11 is giving error. Upon checking, the value read is in Uint8List with 4 elements, which is a binary coded date.
I am not entirely sure if all MRTD document's birthdates are binary coded, so I apply a length checking on the birthdate value. If it is 4 bytes (length of 4), then it is likely to be binary coded and therefore attempt to convert it accordingly. Otherwise, it will fallback to the original date conversion using String.fromCharCodes