fix: List component #277
Open
fix: List component #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| width: Union[int, str] = Field("100%", description="Width of the List item") | ||
| height: Union[int, str] = Field("100%", description="Height of the List item") | ||
| value: str = Field("", description="value for List Item") |
There was a problem hiding this comment.
Is value used on this?
There was a problem hiding this comment.
Created the attribute as per the props in v-list-item API Docs
There was a problem hiding this comment.
What is value used for in this context
zt_backend/models/components/list.py
Outdated
| childComponents: List[str] = Field( | ||
| [], description="List of child component ids to be placed within the List" | ||
| ) | ||
| color: str = Field(None, description="Background color of the List") |
There was a problem hiding this comment.
Default for all should not be None
There was a problem hiding this comment.
zt_backend/models/components/list.py
Outdated
| [], | ||
| description="List of child component ids to be placed within the ListItemTitle. Mention v-test component to show the text of Subtitle", | ||
| ) | ||
| opacity: Union[int, str] = Field("50%", description="opacity for subtitle") |
There was a problem hiding this comment.
Test out defaults here, how is this changing visually in the notebook?
There was a problem hiding this comment.
opacity is not working even after changing the values.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
ListComponent
ListGroup
ListItem
ListItemTitle
ListItemSubtitle
ListSubheader