Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include token_type_ids when building model inputs #32

Merged
merged 3 commits into from
Jan 23, 2024
Merged

include token_type_ids when building model inputs #32

merged 3 commits into from
Jan 23, 2024

Conversation

weswalla
Copy link
Contributor

@weswalla weswalla commented Jan 22, 2024 •
edited
Loading

added token_type_ids to the buildModelInputs method of the BertTokenizer class as some models require it as an input.

@weswalla
Copy link
Contributor Author

@ZachNagengast let me know if there is anything else you'd like me to change. Do you use a specific formatter?

ZachNagengast
ZachNagengast approved these changes Jan 23, 2024
View reviewed changes
Copy link
Owner

@ZachNagengast ZachNagengast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for contributing! 🎉

@ZachNagengast
Copy link
Owner

@ZachNagengast let me know if there is anything else you'd like me to change. Do you use a specific formatter?

Nothing set in stone at the moment, I want to revamp the CI scripts and will add a linter at that point 💪

@ZachNagengast ZachNagengast merged commit ddc8e45 into ZachNagengast:main Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZachNagengast ZachNagengast ZachNagengast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weswalla @ZachNagengast