Top k improved search #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dings.swift Co-authored-by: Zach Nagengast <[email protected]>
…dings.swift Co-authored-by: Zach Nagengast <[email protected]>
I didnt see a reason why this function has to be private and i need to access the file location from outside.
added documentation
…ogel/similarity-search-kit into topK-improvedSearch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Zach,
I just added an improved sorting algorithm (which makes the program substantially faster) in the file topK and added the function getDefaultStorageFilePath in SimilarityIndex to get the complete filePath from outside the class to check if it already exists.
The functions:
are very similarly maned, the first gives the complete file path, the second only the directory. I don't know if it might be a good idea to rename the second to something like "getDefaultStorageDirectoryPath", but I don't know where it gets used.
Greetings
Bernhard