Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix megalinter CPP warnings #83

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Fix megalinter CPP warnings #83

merged 2 commits into from
Nov 25, 2024

Conversation

m-ringler
Copy link
Contributor

@m-ringler m-ringler commented Nov 25, 2024

Description

Fix the megalinter complaints of run https://github.com/ZEISS/czicompress/actions/runs/12010544734

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Run tests during build.

Checklist

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the patch version of czicompress
  • Existing unit tests pass locally with my changes.

@m-ringler m-ringler added the cla Contributor License Agreement sent to Admin label Nov 25, 2024
@m-ringler m-ringler self-assigned this Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.93%. Comparing base (a0224b9) to head (6496bab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   77.93%   77.93%           
=======================================
  Files          59       59           
  Lines        1917     1917           
  Branches      120      120           
=======================================
  Hits         1494     1494           
  Misses        399      399           
  Partials       24       24           
Components Coverage Δ
czicompress 66.75% <ø> (ø)
czishrink 80.71% <ø> (ø)
---- 🚨 Try these New Features:

@m-ringler m-ringler marked this pull request as ready for review November 25, 2024 14:48
@m-ringler m-ringler requested a review from a team November 25, 2024 14:48
Copy link
Contributor

@ptahmose ptahmose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@m-ringler m-ringler merged commit ad2dd15 into main Nov 25, 2024
19 checks passed
@m-ringler m-ringler deleted the bugfix/fix-megalinter-build branch November 25, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants